efl_ui_tab_bar: implement efl.ui.single_selectable
ClosedPublic
Actions

Authored by bu5hm4n on Aug 23 2019, 10:46 AM.

Details

Reviewers

zmike
segfaultxavi
cedric
woohyun
bowonryu

Commits

rEFL3c317618e53c: efl_ui_tab_bar: implement efl.ui.single_selectable

Summary

this is for now the simples way IMO, the one or another implementation
thing in efl_ui_tab_pager is a little bit clumsy, but that should be
able to be improved once Efl.Pack_Linear is implemented.

Depends on D9728

Diff Detail

Repository

rEFL core/efl

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

bu5hm4n created this revision.Aug 23 2019, 10:46 AM

Herald added a project: efl. · View Herald TranscriptAug 23 2019, 10:46 AM

Herald added subscribers: committers, reviewers. · View Herald Transcript

bu5hm4n requested review of this revision.Aug 23 2019, 10:46 AM

bu5hm4n added a child revision: D9730: efl_ui_tab_bar: migrate to Efl.Pack_Linear.

Harbormaster completed remote builds in B12926: Diff 24457.Aug 23 2019, 10:48 AM

rebase

Harbormaster completed remote builds in B13012: Diff 24583.Aug 28 2019, 11:43 PM

woohyun accepted this revision.Aug 29 2019, 4:23 AM

This revision is now accepted and ready to land.Aug 29 2019, 4:23 AM

rebase

Harbormaster completed remote builds in B13027: Diff 24604.Aug 29 2019, 5:41 AM

Closed by commit rEFL3c317618e53c: efl_ui_tab_bar: implement efl.ui.single_selectable (authored by Marcel Hollerbach <mail@marcel-hollerbach.de>). · Explain WhyAug 29 2019, 5:43 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			src/lib/elementary/efl_ui_tab_bar.c (40 lines)
M			src/lib/elementary/efl_ui_tab_bar.eo (22 lines)
M			src/lib/elementary/efl_ui_tab_bar_private.h (4 lines)
M			src/lib/elementary/efl_ui_tab_pager.c (24 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	24457	3391c2e		Aug 23 2019, 10:46 AM	★	★
Diff 2	24583	8735a6e	rebase	Aug 28 2019, 11:43 PM	★	★
Diff 3	24604	52b4445	rebase	Aug 29 2019, 5:41 AM	★	★
Diff 4	24610	f52a0b2	rEFL3c317618e53cd74746fd6e8923091e4a073845f5	Aug 29 2019, 5:42 AM	★	★

Status	Author	Revision
Closed	bu5hm4n	D9706 efl_ui_radio_group: migrate to Efl.Ui.Single_Selectable
Closed	bu5hm4n	D9664 efl_ui_collection: honor desktop vs. touch setting of elm config
Closed	bu5hm4n	D9663 efl_input_clickable: add a flag for showing user interaction
Closed	bu5hm4n	D9662 efl_ui_single_selectable: add properties and events
Closed	bu5hm4n	D9661 suite_helpers: punsh some sanity into function names
Closed	bu5hm4n	D9660 efl_ui_multi_selectable: add APIs for selecting
Closed	bu5hm4n	D9659 efl_ui_spec_suite: that fixture is unneeded
Abandoned	bu5hm4n	D9857 efl_ui_widget: do not crash if a parent was set that is not a widget
Closed	bu5hm4n	D9762 efl_ui_widget: refactor constructor
Closed	bu5hm4n	D9732 efl_ui_tab_pager: make this compatible with Efl.Pack_Linear test suite
Closed	bu5hm4n	D9731 efl_ui_tab_pager: remove the setter for tab_bar
Closed	bu5hm4n	D9730 efl_ui_tab_bar: migrate to Efl.Pack_Linear
Closed	bu5hm4n	D9729 efl_ui_tab_bar: implement efl.ui.single_selectable
Closed	bu5hm4n	D9728 efl_ui_tab_page: remove part
Closed	bu5hm4n	D9727 efl_ui_tab_bar: remove update event
Closed	bu5hm4n	D9726 introduce efl_ui_tab_bar_default_item
Closed	bu5hm4n	D9723 efl_ui_item: add keybindings for selecting changes
Closed	bu5hm4n	D9722 efl_ui_item: only fetch multiselection state if this is relevant