efl_ui_tab_bar: migrate to Efl.Pack_Linear
ClosedPublic
Actions

Authored by bu5hm4n on Aug 23 2019, 10:46 AM.

Details

Reviewers

zmike
segfaultxavi
cedric
woohyun
bowonryu

Commits

rEFLffafe749ed9c: efl_ui_tab_bar: migrate to Efl.Pack_Linear

Summary

with pack linear it is a lot more convinient and error prover to add
items to this widget, this also comes with the pack test suite, which
verifies that this behaviour is not broken. Additionally we have fewer
APIs that a user has to learn.

Depends on D9729

Diff Detail

Repository

rEFL core/efl

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

bu5hm4n created this revision.Aug 23 2019, 10:46 AM

Herald added a project: efl. · View Herald TranscriptAug 23 2019, 10:46 AM

Herald added subscribers: committers, reviewers. · View Herald Transcript

bu5hm4n requested review of this revision.Aug 23 2019, 10:46 AM

bu5hm4n added a child revision: D9731: efl_ui_tab_pager: remove the setter for tab_bar.

Harbormaster completed remote builds in B12927: Diff 24458.Aug 23 2019, 10:48 AM

rebase

Harbormaster completed remote builds in B13013: Diff 24584.Aug 28 2019, 11:43 PM

woohyun accepted this revision.Aug 29 2019, 4:22 AM

This revision is now accepted and ready to land.Aug 29 2019, 4:22 AM

rebase

Harbormaster completed remote builds in B13028: Diff 24605.Aug 29 2019, 5:41 AM

Closed by commit rEFLffafe749ed9c: efl_ui_tab_bar: migrate to Efl.Pack_Linear (authored by Marcel Hollerbach <mail@marcel-hollerbach.de>). · Explain WhyAug 29 2019, 5:43 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			src/lib/elementary/efl_ui_tab_bar.c (182 lines)
M			src/lib/elementary/efl_ui_tab_bar.eo (21 lines)
M			src/lib/elementary/efl_ui_tab_bar_private.h (5 lines)
M			src/lib/elementary/efl_ui_tab_pager.c (28 lines)
M			src/tests/elementary/spec/efl_test_pack_linear.c (5 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	24458	3289970		Aug 23 2019, 10:46 AM	★	★
Diff 2	24584	0ab4720	rebase	Aug 28 2019, 11:43 PM	★	★
Diff 3	24605	2747a9b	rebase	Aug 29 2019, 5:41 AM	★	★
Diff 4	24609	3c31761	rEFLffafe749ed9c813696929262aacb61fd5af0ecc2	Aug 29 2019, 5:42 AM	★	★

Status	Author	Revision
Closed	bu5hm4n	D9706 efl_ui_radio_group: migrate to Efl.Ui.Single_Selectable
Closed	bu5hm4n	D9664 efl_ui_collection: honor desktop vs. touch setting of elm config
Closed	bu5hm4n	D9663 efl_input_clickable: add a flag for showing user interaction
Closed	bu5hm4n	D9662 efl_ui_single_selectable: add properties and events
Closed	bu5hm4n	D9661 suite_helpers: punsh some sanity into function names
Closed	bu5hm4n	D9660 efl_ui_multi_selectable: add APIs for selecting
Closed	bu5hm4n	D9659 efl_ui_spec_suite: that fixture is unneeded
Abandoned	bu5hm4n	D9857 efl_ui_widget: do not crash if a parent was set that is not a widget
Closed	bu5hm4n	D9762 efl_ui_widget: refactor constructor
Closed	bu5hm4n	D9732 efl_ui_tab_pager: make this compatible with Efl.Pack_Linear test suite
Closed	bu5hm4n	D9731 efl_ui_tab_pager: remove the setter for tab_bar
Closed	bu5hm4n	D9730 efl_ui_tab_bar: migrate to Efl.Pack_Linear
Closed	bu5hm4n	D9729 efl_ui_tab_bar: implement efl.ui.single_selectable
Closed	bu5hm4n	D9728 efl_ui_tab_page: remove part
Closed	bu5hm4n	D9727 efl_ui_tab_bar: remove update event
Closed	bu5hm4n	D9726 introduce efl_ui_tab_bar_default_item
Closed	bu5hm4n	D9723 efl_ui_item: add keybindings for selecting changes
Closed	bu5hm4n	D9722 efl_ui_item: only fetch multiselection state if this is relevant