Page MenuHomePhabricator

eina/array: added eina_array_find() api to eina_array.
ClosedPublic

Authored by smohanty on Aug 25 2019, 5:34 PM.

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
smohanty created this revision.Aug 25 2019, 5:34 PM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

smohanty requested review of this revision.Aug 25 2019, 5:34 PM
Hermet requested changes to this revision.Aug 25 2019, 11:07 PM

Please check typos.

src/lib/eina/eina_array.h
420

if found other wise => if found, otherwise

422

serach => search
data__in => data_in

423

foud =>found

425

please add @since 1.23

This revision now requires changes to proceed.Aug 25 2019, 11:07 PM
smohanty updated this revision to Diff 24485.Aug 26 2019, 2:23 AM

updated review comment

smohanty marked 4 inline comments as done.Aug 26 2019, 2:25 AM
segfaultxavi requested changes to this revision.Aug 26 2019, 2:46 AM
segfaultxavi added a subscriber: segfaultxavi.
segfaultxavi added inline comments.
src/lib/eina/eina_array.h
419

out_idx is an [out] parameter.

422

Correct me if I am wrong, but I would say:

This function searches for the data pointer @p data inside @p array, returning @c EINA_TRUE if found.
The exact position where the pointer is found can be retrieved through @p out_idx.
Please note that only the pointer is compared, not the actual data pointed by it.
@since 1.23
This revision now requires changes to proceed.Aug 26 2019, 2:46 AM
smohanty updated this revision to Diff 24489.Aug 26 2019, 3:09 AM

updated docs wording from Xavi Artigas.

smohanty marked 2 inline comments as done.Aug 26 2019, 3:10 AM
segfaultxavi accepted this revision.Aug 26 2019, 3:38 AM
zmike accepted this revision.Aug 26 2019, 5:04 AM
ProhtMeyhet requested changes to this revision.Aug 26 2019, 5:27 AM
In D9734#180629, @Herald wrote:

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

src/lib/eina/eina_array.h
426

there is unused whitespace. a space \s too much, between the Eina_Bool and eina_array_find.

src/tests/eina/eina_test_array.c
187

i\s=1 vs i\s<\s10

201

useless new line

This revision now requires changes to proceed.Aug 26 2019, 5:27 AM
This revision was not accepted when it landed; it landed in state Needs Revision.Aug 26 2019, 5:31 AM
Closed by commit rEFL5bd95c9850df: eina/array: added eina_array_find() api to eina_array. (authored by sub.mohanty@samsung.com <sub.mohanty@samsung.com>, committed by zmike). · Explain Why
This revision was automatically updated to reflect the committed changes.