Page MenuHomePhabricator

elementary: Initialize object position in widget_factory building

Authored by SanghyeonLee on Aug 26 2019, 9:17 PM.



created object from factory need to be initialize their position
to be not shown in the viewport geometry.

Diff Detail

rEFL core/efl
No Linters Available
No Unit Test Coverage
Build Status
Buildable 12969
Build 9238: arc lint + arc unit
SanghyeonLee created this revision.Aug 26 2019, 9:17 PM
SanghyeonLee requested review of this revision.Aug 26 2019, 9:17 PM

We can also just set the visibility to false, so we minimize the elements that the renderer is touching. However there are way more issues waiting in T8180 that are also in this code.

After thinking more about this, i think this makes sense to have in master right now...

But its conflicting.

I’ll rebase it

@cedric do you want to pull this into your branch ?

I will pull this one in my branch.

zmike added a comment.Sep 23 2019, 1:48 PM

What happened with this

I could not apply this patch. Could you rebase it again? Sorry.

not sure we still need this patch or not,
let me try without this patch and if it need I'll rebase the patch.

seems we don't need this patch anymore as I tested in efl_ui_list_view_example_1
let me wait till tomorrow and no other comments, I'll drop it.

SanghyeonLee abandoned this revision.Sep 26 2019, 4:44 AM