Page MenuHomePhabricator

edje/load: pass Edje_File instead of Edje to _edje_extract_mo_files()
ClosedPublic

Authored by smohanty on Aug 27 2019, 3:26 AM.

Details

Summary

Why :

  1. The function operates on the Edje_File level not on Edje object level , so express it clearly in the function argument.
  2. if its clear that this function works on file level then this should be called when the theme file loaded for the first time not on every Edje object creation.

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
smohanty created this revision.Aug 27 2019, 3:26 AM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

smohanty requested review of this revision.Aug 27 2019, 3:26 AM
smohanty added inline comments.Aug 27 2019, 3:46 AM
src/lib/edje/edje_load.c
849

these 2 line should move to edje_cache (during file load for the first time . if the reviewer agrees will update this patch with the change , otherwise will raise a separate patch

zmike added inline comments.Aug 27 2019, 4:51 AM
src/lib/edje/edje_load.c
849

I'm okay with it being a single patch as long as you update the first line of the commit to reflect that.

smohanty added inline comments.Aug 27 2019, 5:02 AM
src/lib/edje/edje_load.c
849

so we agree that this function should be called during the file open (in edje_cache.c)

if there is no other issue . then you can accept this patch . will create new patch tomorrow which will move this function to its appropriate place.

zmike accepted this revision.Aug 27 2019, 5:04 AM
zmike added inline comments.
src/lib/edje/edje_load.c
849

Oh ok.

This revision is now accepted and ready to land.Aug 27 2019, 5:04 AM
Closed by commit rEFL05ea1854a921: edje/load: pass Edje_File instead of Edje to _edje_extract_mo_files() (authored by subhransu mohanty <sub.mohanty@samsung.com>, committed by zmike). · Explain WhyAug 27 2019, 5:27 AM
This revision was automatically updated to reflect the committed changes.