Page MenuHomePhabricator

edje/style/optimization: Enable lazy computaion of styles.
ClosedPublic

Authored by smohanty on Aug 28 2019, 7:38 PM.

Details

Summary

As user request for the evas_textblock_style through _edje_textblock_style_get()
api and that api implements lazy computation of the styles. By just marking the
style dirty (stl->cache=false) will be enough. no need to calculate the style
computaion at that time.

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
smohanty created this revision.Aug 28 2019, 7:38 PM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

smohanty requested review of this revision.Aug 28 2019, 7:38 PM
Hermet requested changes to this revision.Aug 28 2019, 8:04 PM

Please check a comment.

src/lib/edje/edje_textblock_styles.c
149

No, we should not use CRI unless it could break the process and memory.

This revision now requires changes to proceed.Aug 28 2019, 8:04 PM
smohanty updated this revision to Diff 24571.Aug 28 2019, 8:31 PM

updated review comment

smohanty marked an inline comment as done.Aug 28 2019, 8:32 PM
smohanty added inline comments.
src/lib/edje/edje_textblock_styles.c
149

changed to ERR()

Hermet accepted this revision.Aug 28 2019, 10:32 PM
This revision is now accepted and ready to land.Aug 28 2019, 10:32 PM
Closed by commit rEFLe2663ba8f38c: edje/style/optimization: Enable lazy computaion of styles. (authored by subhransu mohanty <sub.mohanty@samsung.com>, committed by Hermet). · Explain WhyAug 28 2019, 10:32 PM
This revision was automatically updated to reflect the committed changes.