Page MenuHomePhabricator
Differential D9811

efl_ui_timepicker: change a property name (ampm -> is_24hour)
ClosedPublic
Actions

Authored by woohyun on Sep 1 2019, 11:07 PM.

Details

Reviewers
zmike
segfaultxavi
bu5hm4n
kimcinoo
Maniphest Tasks
T7901: efl.ui.timepicker
Commits
rEFLd61cf9df7308: efl_ui_timepicker: change a property name (ampm -> is_24hour)
Summary

For better understanding of the property, "is_24hour" looks
better than "ampm".

@ref T7901

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
woohyun created this revision.Sep 1 2019, 11:07 PM
Herald added a project: efl. · View Herald TranscriptSep 1 2019, 11:07 PM
Herald added subscribers: committers, reviewers, cedric. · View Herald Transcript

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

woohyun requested review of this revision.Sep 1 2019, 11:07 PM
kimcinoo accepted this revision.Sep 1 2019, 11:38 PM
kimcinoo added a subscriber: kimcinoo.

Looks good to me. It seems that 24 hour is more familiar at least in the android developers' world as well - https://developer.android.com/reference/android/widget/TimePicker.html#is24HourView()

This revision is now accepted and ready to land.Sep 1 2019, 11:38 PM
segfaultxavi accepted this revision.Sep 2 2019, 12:09 AM
Closed by commit rEFLd61cf9df7308: efl_ui_timepicker: change a property name (ampm -> is_24hour) (authored by woohyun, committed by kimcinoo). · Explain WhySep 3 2019, 10:11 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 24736

View Options

src/lib/elementary/efl_ui_timepicker.c

Loading...
View Options

src/lib/elementary/efl_ui_timepicker.eo

Loading...