Page MenuHomePhabricator
Differential D9816

eolian-mono: Removing I prefix from classes.
ClosedPublic
Actions

Authored by brunobelo on Sep 2 2019, 1:46 PM.

Details

Reviewers
lauromoura
felipealmeida
Maniphest Tasks
T8166: C#: Remove I prefix from regular classes
Commits
rEFLb36e159d313b: eolian-mono: Removing I prefix from classes.

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
brunobelo created this revision.Sep 2 2019, 1:46 PM
brunobelo requested review of this revision.Sep 2 2019, 1:46 PM
lauromoura requested changes to this revision.Sep 2 2019, 7:52 PM

This looks good for the *Concrete classes.

For T8166 it still needs to remove the I from the *EventArgs (assuming D9692 is in) classes.

As this patch already fixes class_concrete_name, we could start using it for these EventArgs classes (removing the Concrete suffix, though).

This revision now requires changes to proceed.Sep 2 2019, 7:52 PM
brunobelo updated this revision to Diff 24713.Sep 3 2019, 7:58 AM

Removing I from Concrete and EventArgs classes.

lauromoura accepted this revision.Sep 3 2019, 3:51 PM
This revision is now accepted and ready to land.Sep 3 2019, 3:51 PM
Closed by commit rEFLb36e159d313b: eolian-mono: Removing I prefix from classes. (authored by brunobelo, committed by segfaultxavi). · Explain WhySep 6 2019, 7:06 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 24809

View Options

src/bin/eolian_mono/eolian/mono/name_helpers.hh

Loading...
View Options

src/bindings/mono/efl_mono/GenericModel.cs

Loading...
View Options

src/tests/efl_mono/Model.cs

Loading...