(uint) - (int) results in the type uint. which ... cannot get negative,
so this compare function will always tell you either 0 or > 0.
Details
Details
- Reviewers
cedric
Diff Detail
Diff Detail
- Repository
- rEFL core/efl
- Branch
- master
- Lint
Lint OK - Unit
No Unit Test Coverage - Build Status
Buildable 13115
Comment Actions
It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/
src/lib/ecore/efl_composite_model.c | ||
---|---|---|
45 | If we do not expect node->index to be greater than 2^31 we can shorten this to return (int)node->index - *key, no? |
src/lib/ecore/efl_composite_model.c | ||
---|---|---|
45 | There has been no review of what an index range is in mvvm and it would be a good things to do. Make a decision and make sure all our API follow it. |