Page MenuHomePhabricator
Differential D9836

efl_composite_model: make sure we are having a cmp method that works
AbandonedPublic
Actions

Authored by bu5hm4n on Sep 4 2019, 8:08 AM.

Details

Reviewers
cedric
Summary

(uint) - (int) results in the type uint. which ... cannot get negative,
so this compare function will always tell you either 0 or > 0.

Diff Detail

Repository
rEFL core/efl
Branch
master
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 13115
bu5hm4n created this revision.Sep 4 2019, 8:08 AM
Herald added a project: efl. · View Herald TranscriptSep 4 2019, 8:08 AM
Herald added subscribers: committers, reviewers, cedric. · View Herald Transcript

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

bu5hm4n requested review of this revision.Sep 4 2019, 8:08 AM
segfaultxavi added a subscriber: segfaultxavi.Sep 4 2019, 8:35 AM
segfaultxavi added inline comments.
src/lib/ecore/efl_composite_model.c
45

If we do not expect node->index to be greater than 2^31 we can shorten this to return (int)node->index - *key, no?

cedric added inline comments.Sep 4 2019, 6:40 PM
src/lib/ecore/efl_composite_model.c
45

There has been no review of what an index range is in mvvm and it would be a good things to do. Make a decision and make sure all our API follow it.

cedric accepted this revision.Oct 31 2019, 10:22 AM

Let's land this one and I will look into stabilizing our MVVM range infor.

This revision is now accepted and ready to land.Oct 31 2019, 10:22 AM
cedric added a comment.Oct 31 2019, 10:23 AM

Actually this has already been fixed in master. Can you abandon?

bu5hm4n abandoned this revision.Nov 20 2019, 1:08 AM

Revision Contents
Changeset List

Diff 24740

View Options

src/lib/ecore/efl_composite_model.c

Loading...