Page MenuHomePhabricator

evas_textblock: fix compilation without harfbuzz
ClosedPublic

Authored by ali.alzyod on Sep 5 2019, 1:10 AM.

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ali.alzyod created this revision.Sep 5 2019, 1:10 AM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

ali.alzyod requested review of this revision.Sep 5 2019, 1:10 AM
bu5hm4n requested changes to this revision.Sep 5 2019, 1:23 AM
bu5hm4n added inline comments.
src/lib/evas/canvas/evas_object_textblock.c
9670

We normally do not solve that this way, normally we just leave the attributes in the parameterlist, but add something like:

#ifndef OT_SUPPORT
(void)is_single_glypth;
#endif

This keeps all this easier.

This revision now requires changes to proceed.Sep 5 2019, 1:23 AM
ali.alzyod marked an inline comment as done.Sep 5 2019, 1:29 AM
bu5hm4n accepted this revision.Sep 5 2019, 1:34 AM

That patch does not compile, as is_single_glypth does not exist, i fixed that now locally and just pushed it.

This revision is now accepted and ready to land.Sep 5 2019, 1:34 AM
Closed by commit rEFL155f2f98af9f: evas_textblock: fix compilation without harfbuzz (authored by ali.alzyod, committed by Marcel Hollerbach <mail@marcel-hollerbach.de>). · Explain WhySep 5 2019, 1:34 AM
This revision was automatically updated to reflect the committed changes.