Page MenuHomePhabricator

evas filter: Implement grayscale filter in pure GL
Needs RevisionPublic

Authored by kimcinoo on Fri, Sep 6, 4:01 AM.

Details

Reviewers
Hermet
jsuya
Summary

Initial version implementing grayscale filter in pure GL.
This patch needs a logt of love as 5bce712 did.

Test Plan
  1. Create filter_example with following .

efl_gfx_filter_program_set(image, "grayscale ()", "grayscale");

  1. Run.

ELM_ACCEL=gl ./filter_example

Diff Detail

Repository
rEFL core/efl
Branch
efl.gfx.filter_add.grayscale.filter
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 13150
Build 9343: arc lint + arc unit
kimcinoo created this revision.Fri, Sep 6, 4:01 AM
kimcinoo requested review of this revision.Fri, Sep 6, 4:01 AM
kimcinoo edited the test plan for this revision. (Show Details)Fri, Sep 6, 4:05 AM
Hermet requested changes to this revision.Wed, Sep 18, 11:54 PM

Overall assembled code looks fine to me some unnecessary debugging prints just bothers other developers to checking logging. (except it occurs performance drop);

+two question.
This grayscale filter (r, r, r, a) is generic one? this logic ignores the brightness since it drop other color channels, Were did you get this method?

+will you go work for sw backend?

src/lib/evas/filters/evas_filter.c
1610
in = _filter_buffer_get(ctx, inbuf);
EINA_SAFETY_ON_NULL_RETURN_VAL(in, NULL);

out = _filter_buffer_get(ctx, outbuf);
EINA_SAFETY_ON_NULL_RETURN_VAL(out, NULL);
src/modules/evas/engines/gl_generic/filters/gl_filter_grayscale.c
6

no debugging.

23

if it doesn't necessary i'd like to suggest remove it.

This revision now requires changes to proceed.Wed, Sep 18, 11:54 PM