Page MenuHomePhabricator

efl.ui.scrollable: fix event name for scrollable
ClosedPublic

Authored by eagleeye on Sep 6 2019, 4:23 AM.

Details

Summary

Event name is applied in the past tense.
Meaning of 'stop' is 'stop it early', so I changed it to 'finish'

Test Plan

elementary_test -> efl.ui.scroller

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
eagleeye created this revision.Sep 6 2019, 4:23 AM
eagleeye requested review of this revision.Sep 6 2019, 4:23 AM
segfaultxavi requested changes to this revision.Sep 6 2019, 6:42 AM

Looks good, and I agree with the rename. Just a minor nitpick.

src/lib/efl/interfaces/efl_ui_scrollable.eo
20

Probably [[Called when scroll drag finishes.]]

This revision now requires changes to proceed.Sep 6 2019, 6:42 AM

@zmike

These days, we are in long holidays in Korea. Sorry for late reply and I will ask @eagleeye to answer soon.

eagleeye updated this revision to Diff 25039.Mon, Sep 16, 1:10 AM

fix comment in efl_ui_scrollable.eo

segfaultxavi accepted this revision.Mon, Sep 16, 2:51 AM
This revision is now accepted and ready to land.Mon, Sep 16, 2:51 AM
Closed by commit rEFLa6aa1b912e12: efl.ui.scrollable: fix event name for scrollable (authored by Hosang Kim <hosang12.kim@samsung.com>, committed by segfaultxavi). · Explain WhyMon, Sep 16, 3:04 AM
This revision was automatically updated to reflect the committed changes.

This revision introduced a rather big problem. This *also* renamed the legacy event strings, which is wrong, as it breaks API for the scroller.

Whenever you rename events in a .eo file, *every* usage of that event in a legacy widget has to be updated to continue using the old event name, otherwise this is breaking API.