Page MenuHomePhabricator

efl: check file's mtime in efl.file::file_set to determine if file is the same
ClosedPublic

Authored by zmike on Mon, Sep 9, 7:38 AM.

Details

Summary

historically, if the mtime of an edj file changes after being loaded,
the edje file should be reloaded. this needs to occur in a single call
with the previous user definitions intact, so verify that the mtime is
the same in efl.file::file_set when using the same file name

@fix

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
zmike created this revision.Mon, Sep 9, 7:38 AM
zmike requested review of this revision.Mon, Sep 9, 7:38 AM
cedric added a comment.Mon, Sep 9, 9:56 AM

I feel like this code would be simpler if instead we were to use an Eina_File along efl_file_mmap_set. Wouldn't that always work without the need to do the if case at all?

zmike updated this revision to Diff 24920.Wed, Sep 11, 9:13 AM
zmike retitled this revision from edje: restore legacy load behavior in edje_object_file_set() to efl: check file's mtime in efl.file::file_set to determine if file is the same.
zmike edited the summary of this revision. (Show Details)

rework to be handled inside efl.file

cedric accepted this revision.Wed, Sep 11, 9:20 AM

I will let you land the patch, but don't forget to update the commit message appropriately.

This revision is now accepted and ready to land.Wed, Sep 11, 9:20 AM
zmike edited the summary of this revision. (Show Details)Wed, Sep 11, 9:22 AM
This revision was automatically updated to reflect the committed changes.