Page MenuHomePhabricator
Differential D9882

efl_ui/popup: improve docs
ClosedPublic
Actions

Authored by zmike on Sep 9 2019, 9:22 AM.

Details

Reviewers
segfaultxavi
Maniphest Tasks
T7717: docs todo
Commits
rEFL08e5b09d0a98: efl_ui/popup: improve docs
Summary

this provides full documentation for the class and all properties

ref T7717

Diff Detail

Repository
rEFL core/efl
Branch
master
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 13219
zmike created this revision.Sep 9 2019, 9:22 AM
zmike requested review of this revision.Sep 9 2019, 9:22 AM
segfaultxavi requested changes to this revision.Sep 10 2019, 1:42 AM

I normally accept docs as they come, and later spend time fixing them myself. But this one is so close to perfection that if you just amended these little nitpicks, I can accept it as-is and forget about it ?

src/lib/elementary/efl_ui_popup.eo
71–72

The default is to not automatically delete the Popup.: And what value does that?

This also brings the topic of whether timers can be cancelled. This should be explained in the above paragraph.

86

Normally all NULLs are written $NULL.

112–116

Missing @ refs.

This revision now requires changes to proceed.Sep 10 2019, 1:42 AM
zmike updated this revision to Diff 24888.Sep 10 2019, 6:08 AM

improve improvements

segfaultxavi accepted this revision.Sep 10 2019, 6:47 AM
This revision is now accepted and ready to land.Sep 10 2019, 6:47 AM
Closed by commit rEFL08e5b09d0a98: efl_ui/popup: improve docs (authored by zmike, committed by segfaultxavi). · Explain WhySep 10 2019, 6:47 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
~src/lib/elementary/efl_ui_popup.eo (107 lines)

Diff 24888

View Options

src/lib/elementary/efl_ui_popup.eo

Loading...