Page MenuHomePhabricator
Differential D9883

efl_ui/alert_popup: improve docs
ClosedPublic
Actions

Authored by zmike on Sep 9 2019, 9:54 AM.

Details

Reviewers
segfaultxavi
Maniphest Tasks
T7717: docs todo
Commits
rEFL6d49eb7cc272: efl_ui/alert_popup: improve docs
Summary

class and property docs

ref T7717

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
zmike created this revision.Sep 9 2019, 9:54 AM
zmike requested review of this revision.Sep 9 2019, 9:54 AM
segfaultxavi requested changes to this revision.Sep 10 2019, 2:07 AM
segfaultxavi added inline comments.
src/lib/elementary/efl_ui_alert_popup.eo
32

For completeness' sake, once a button has been created, can it be removed?

This revision now requires changes to proceed.Sep 10 2019, 2:07 AM
zmike added inline comments.Sep 10 2019, 6:06 AM
src/lib/elementary/efl_ui_alert_popup.eo
32

Buttons can't be removed. Is that a problem?

segfaultxavi added inline comments.Sep 10 2019, 6:41 AM
src/lib/elementary/efl_ui_alert_popup.eo
32

Not at all, just thought it might be worth saying so in the docs.

segfaultxavi accepted this revision.Sep 10 2019, 8:10 AM
This revision is now accepted and ready to land.Sep 10 2019, 8:10 AM
Closed by commit rEFL6d49eb7cc272: efl_ui/alert_popup: improve docs (authored by zmike, committed by segfaultxavi). · Explain WhySep 10 2019, 8:10 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 24894

View Options

src/lib/elementary/efl_ui_alert_popup.eo

Loading...