Details
Diff Detail
- Repository
- rEFL core/efl
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/
I removed the patch, I have an infinite loop that appears at the launch of applications, when starting E.
On the other hand the virtual keyboard is visible on lightdm.
the output in xsession-errors with the patch applied. :
the output in xsession-errors with your modified patch:
patch modified:
If you need more precision ...
E version : 0.23.0+0aea2d23a757
EFL : 1.22.4
I start E and I run elementary_test
]$ top PID USER PR NI VIRT RES SHR S %CPU %MEM TIME+ COMMAND 14777 ordissi+ 20 0 2182996 710492 58424 R 100,0 18,0 74:42.05 enlightenment
Hm the modified patch you've posted here seems like it is broken according to wm specs; the issue is that the window should be waiting for the wm to configure it once it is shown, but you've subverted that by toggling the configured flag if the environment is a compositing wm (and added a roundtrip to every event).
I'm testing here with the latest EFL from master (rEFL3932c6838292472b14f6dcfd90e74c59554c9524) and this patch applied on top: things seem to work as expected in Enlightenment 0.23 as well as other WMs. I'm wondering if this is an issue with the 1.22 branch somehow...
I have a few things to finish, then I will wear the top version of the EFL-1.23.xxxx,
I tell you that quickly.
I've just tested on 1.22.4 and it does indeed seem to fail there. Will examine this a little more...
Hm after quite some time looking into this, I've run out of time. There's some sort of X11 protocol handling race condition which triggers under enlightenment/efl in 1.22 but is resolved in 1.23. I'll skip backporting this, but it does seem to fix the issue in 1.23.
@thierry1970 hey, with the patches I've just added to this series everything should be fixed even in 1.22.
src/modules/ecore_evas/engines/x/ecore_evas_x.c | ||
---|---|---|
1912 | Huh ?? Wasn't this just defined in https://phab.enlightenment.org/D10013 ... I would think that you shouldn't need this declaration here (assuming ecore_evas_x is included ecore_x_private.h).... |
src/modules/ecore_evas/engines/x/ecore_evas_x.c | ||
---|---|---|
1912 | It isn't. |