Page MenuHomePhabricator

theme: redo scroller theme of elm

Authored by bu5hm4n on Sep 11 2019, 2:59 AM.



this was a little bit weird. There was a script that did what we already
do in C and pass it on via signals, however, there was also somewhere a
bug in this script, the arrow was not getting enabled, even if the
position is not completly max and not completly min, the problem here
was that the numbers that are passed to edje are not 100% correct (I
think they got somehwere on the way casted to an int).

With this commit we just use the signals from c in the theme and replace
the theme, this should also make everything a bit easier on the
mainloop, as a single movement of the scroller does not schedule 10
timers anymore.

ref T4918

Diff Detail

rEFL core/efl
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
bu5hm4n created this revision.Sep 11 2019, 2:59 AM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added:

zmike requested changes to this revision.Sep 11 2019, 7:39 AM
zmike added reviewers: eagleeye, woohyun.
zmike added a subscriber: zmike.

This removes handling for elm.loop_x,unset and elm,loop_y,unset. There is also an issue where clicking an inactive scroller arrow causes it to become active and triggers scroller bounce.

This revision now requires changes to proceed.Sep 11 2019, 7:39 AM

I could fix the elm.loop_x stuff with a patch to elm_interface_scrollable.c. However, the clicking on a inactive scroller arrow is a little bit more tricky, i have added filters to every program that deals with this, and the result is no difference to before, i also think that we are hitting here some bug in edje, as chaning the position of the scrollbar once, and bringing it back to disabling one arrow will leave you without this bug.

bu5hm4n updated this revision to Diff 24947.Sep 12 2019, 12:43 AM

add filters

zmike requested changes to this revision.Oct 25 2019, 7:06 AM

Hm still not quite there. Clicking the top arrow on elm_test immediately after launching causes it to change to the active state when it should still be grayed out.

This revision now requires changes to proceed.Oct 25 2019, 7:06 AM
zmike added a comment.Oct 25 2019, 7:31 AM

this series also seems to trigger an infinite loop in my recent genlist behavior patchset, implying that something else is (more) broken

bu5hm4n requested review of this revision.Oct 25 2019, 10:43 AM

this bug if fixed in the third revision of this stack :)

zmike accepted this revision.Oct 25 2019, 11:03 AM
This revision is now accepted and ready to land.Oct 25 2019, 11:03 AM
Closed by commit rEFLa23b5452492c: theme: redo scroller theme of elm (authored by Marcel Hollerbach <>, committed by zmike). · Explain WhyOct 25 2019, 11:07 AM
This revision was automatically updated to reflect the committed changes.