Page MenuHomePhabricator

theme: redo scroller theme of elm
Needs ReviewPublic

Authored by bu5hm4n on Wed, Sep 11, 2:59 AM.

Details

Summary

this was a little bit weird. There was a script that did what we already
do in C and pass it on via signals, however, there was also somewhere a
bug in this script, the arrow was not getting enabled, even if the
position is not completly max and not completly min, the problem here
was that the numbers that are passed to edje are not 100% correct (I
think they got somehwere on the way casted to an int).

With this commit we just use the signals from c in the theme and replace
the theme, this should also make everything a bit easier on the
mainloop, as a single movement of the scroller does not schedule 10
timers anymore.

ref T4918

Diff Detail

Repository
rEFL core/efl
Branch
master
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 13251
bu5hm4n created this revision.Wed, Sep 11, 2:59 AM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

zmike requested changes to this revision.Wed, Sep 11, 7:39 AM
zmike added reviewers: eagleeye, woohyun.
zmike added a subscriber: zmike.

This removes handling for elm.loop_x,unset and elm,loop_y,unset. There is also an issue where clicking an inactive scroller arrow causes it to become active and triggers scroller bounce.

This revision now requires changes to proceed.Wed, Sep 11, 7:39 AM

I could fix the elm.loop_x stuff with a patch to elm_interface_scrollable.c. However, the clicking on a inactive scroller arrow is a little bit more tricky, i have added filters to every program that deals with this, and the result is no difference to before, i also think that we are hitting here some bug in edje, as chaning the position of the scrollbar once, and bringing it back to disabling one arrow will leave you without this bug.

bu5hm4n updated this revision to Diff 24947.Thu, Sep 12, 12:43 AM

add filters