Page MenuHomePhabricator

elm_interface_scrollable: correctly emit the signals always
ClosedPublic

Authored by bu5hm4n on Sep 11 2019, 3:00 AM.

Details

Summary

our default theme defaults to show everything, the code here assumes
that everything is hidden by default, this fixes all this.

fix T4918

Depends on D9907

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bu5hm4n created this revision.Sep 11 2019, 3:00 AM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

bu5hm4n requested review of this revision.Sep 11 2019, 3:00 AM
bu5hm4n updated this revision to Diff 24949.Sep 12 2019, 12:43 AM
bu5hm4n edited the summary of this revision. (Show Details)

...

bu5hm4n updated this revision to Diff 26401.Fri, Oct 25, 10:02 AM

fixed a bug where you could click the arrow part, even if the state was set to disabled.

This is caused by the fact that the showing / hiding of the hbar / vbar *always* has to result in signals for arrows beeing shown / hidden, otherwise the theme has to manually track these states, which results in a script, which is something that i tried to avoid here.

zmike accepted this revision.Fri, Oct 25, 10:38 AM
This revision is now accepted and ready to land.Fri, Oct 25, 10:38 AM
Closed by commit rEFLace64dafea13: elm_interface_scrollable: correctly emit the signals always (authored by Marcel Hollerbach <mail@marcel-hollerbach.de>, committed by zmike). · Explain WhyFri, Oct 25, 11:08 AM
This revision was automatically updated to reflect the committed changes.