Page MenuHomePhabricator

tests/edje: handle file modifications properly on windows
ClosedPublic

Authored by zmike on Sep 11 2019, 12:13 PM.

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
zmike created this revision.Sep 11 2019, 12:13 PM
zmike requested review of this revision.Sep 11 2019, 12:13 PM
vtorri added inline comments.Sep 11 2019, 12:31 PM
src/tests/edje/edje_test_edje.c
13

i think that windows.h is sufficient

zmike updated this revision to Diff 24936.Sep 11 2019, 12:45 PM

use windows.h

vtorri added inline comments.Sep 13 2019, 12:47 AM
src/tests/edje/edje_test_edje.c
79

this function returns 0 if it fails

vtorri requested changes to this revision.Sep 13 2019, 1:17 AM
vtorri added inline comments.
src/tests/edje/edje_test_edje.c
72

the second parameter or CreateFile must be GENERIC_READ | GENERIC_WRITE otherwise SetFileTime below fails with

ERROR_ACCESS_DENIED

This revision now requires changes to proceed.Sep 13 2019, 1:17 AM

i can't try the test, but i tried the code on a file, and it works with the change mentioned above

zmike added inline comments.Sep 13 2019, 6:49 AM
src/tests/edje/edje_test_edje.c
72

Oops, missed that

zmike updated this revision to Diff 24983.Sep 13 2019, 6:49 AM

use READ|WRITE

vtorri accepted this revision.Sep 13 2019, 11:12 AM
This revision is now accepted and ready to land.Sep 13 2019, 11:12 AM
This revision was automatically updated to reflect the committed changes.