eina: fix free support in eina OneBig mempool.
ClosedPublic
Actions

Authored by cedric on Sep 15 2019, 11:32 PM.

Details

Reviewers

zmike
stefan_schmidt
bu5hm4n
SanghyeonLee
lauromoura
felipealmeida
segfaultxavi

Maniphest Tasks

T8177: Collection_View Tracking ticket

Commits

rEFLc5c3b04b5c71: eina: fix free support in eina OneBig mempool.
rEFL4ab4b5975750: eina: fix free support in eina OneBig mempool.

Summary

We use an Eina_Trash to store freed pointer, which require the item size
to be at least the size of a pointer. There wasn't any test suite enable
for OneBig mempool and we never used free on a small item size...

Depends on D9938

Diff Detail

Repository

rEFL core/efl

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

cedric created this revision.Sep 15 2019, 11:32 PM

Herald added subscribers: committers, reviewers. · View Herald TranscriptSep 15 2019, 11:32 PM

cedric requested review of this revision.Sep 15 2019, 11:32 PM

cedric added a child revision: D9940: eina: turn on Eina_Mempool tests for OneBig too..

Harbormaster completed remote builds in B13286: Diff 25003.Sep 15 2019, 11:33 PM

Harbormaster completed remote builds in B13291: Diff 25009.Sep 15 2019, 11:36 PM

zmike accepted this revision.Sep 16 2019, 5:29 AM

This revision is now accepted and ready to land.Sep 16 2019, 5:29 AM

Closed by commit rEFL4ab4b5975750: eina: fix free support in eina OneBig mempool. (authored by cedric). · Explain WhySep 17 2019, 10:24 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			src/modules/eina/mp/one_big/eina_one_big.c (3 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	25003	ff50f79		Sep 15 2019, 11:32 PM	★	★
Diff 2	25009	9acdbc9		Sep 15 2019, 11:36 PM	★	★
Diff 3	25103	2064112	rEFL4ab4b5975750e8a1b12ba044d7261714d29a1f63	Sep 17 2019, 10:24 AM	★	★

Status	Author	Revision
Closed	cedric	D9949 elementary: Efl.Ui.Widget_Factory bind widget property before finalizing the widget.
Closed	cedric	D9948 elementary: leverage sizing information from model if available to avoid unecessary calc.
Closed	cedric	D9947 efl_ui_position_manager: a way to announce new entities
Closed	cedric	D9946 elementary: properly shutdown and cleanup Efl.Ui.Position_Manager.
Closed	cedric	D9945 elementary: fix double eina_value_free in Efl.Ui.Homogeneous_Model.property.set
Closed	cedric	D9944 ecore: remove unused variable after code migration. Fix warning.
Closed	cedric	D9943 eina: prevent leak of Eina_Value internal allocation.
Closed	cedric	D10031 efl: improve Efl.Boolean_Model test to enforce Eina_Value type too.
Closed	cedric	D10030 ecore: remove unused piece of code.
Closed	cedric	D10029 ecore: properly initialize all field in event generated by Efl.Generic_Model
Closed	cedric	D10028 ecore: properly initialize the event structure in Efl.Generic_Model.
Closed	cedric	D9942 eina: add code to help debug leaking Eina_Value.
Closed	cedric	D9941 eina: add eina_mempool_iterator_new to slowly iterate every allocated pointer in a mempool.
Closed	cedric	D9940 eina: turn on Eina_Mempool tests for OneBig too.
Closed	cedric	D9939 eina: fix free support in eina OneBig mempool.
Closed	cedric	D9938 eina: fix eina_mempool_from to not report pointer that have never been allocated as allocated.

Diff 25103

View Options

src/modules/eina/mp/one_big/eina_one_big.c