Page MenuHomePhabricator
Differential D9943

eina: prevent leak of Eina_Value internal allocation.
ClosedPublic
Actions

Authored by cedric on Sep 15 2019, 11:37 PM.

Details

Reviewers
zmike
stefan_schmidt
bu5hm4n
SanghyeonLee
lauromoura
felipealmeida
segfaultxavi
Maniphest Tasks
T8177: Collection_View Tracking ticket
Commits
rEFL94e9363649fa: eina: prevent leak of Eina_Value internal allocation.
rEFLb8a897f99eb3: eina: prevent leak of Eina_Value internal allocation.
Summary

eina_value_copy assume the given Eina_Value as target is not initialized
when it copy the source in it. In eina_value_reference_copy we were initialising
before calling eina_value_copy which would then override and leak the internal
pointer no fault of the users.
Depends on D9942

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
cedric created this revision.Sep 15 2019, 11:37 PM
cedric requested review of this revision.Sep 15 2019, 11:37 PM
zmike accepted this revision.Sep 16 2019, 6:08 AM

I don't really see how this avoids a leak since eina_value_copy already calls eina_value_setup internally, but it does remove a redundancy.

This revision is now accepted and ready to land.Sep 16 2019, 6:08 AM
cedric added a comment.Sep 16 2019, 7:49 AM

The double setup trigger a double allocation as it assume the value isn't allocated/initialized and has no way to know.

Closed by commit rEFL94e9363649fa: eina: prevent leak of Eina_Value internal allocation. (authored by cedric). · Explain WhySep 17 2019, 10:24 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 25105

View Options

src/lib/eina/eina_inline_value_util.x

Loading...