elementary: fix double eina_value_free in Efl.Ui.Homogeneous_Model.property.set
ClosedPublic
Actions

Authored by cedric on Sep 15 2019, 11:37 PM.

Details

Reviewers

Maniphest Tasks

T8177: Collection_View Tracking ticket

Commits

Summary

Model do not own the Eina_Value when it is set on them. They can make a copy of it,
but shouldn't free it.
Depends on D9944

Repository

rEFL core/efl

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

cedric requested review of this revision.Sep 15 2019, 11:37 PM

This revision is now accepted and ready to land.Sep 16 2019, 12:29 AM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			src/lib/elementary/efl_ui_homogeneous_model.c (1 line)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	25015	c0b5c7e		Sep 15 2019, 11:37 PM	★	★
Diff 2	25107	9b61831	rEFL3656996df47368692e0a74700b73ba1e766b5850	Sep 17 2019, 10:24 AM	★	★

Status	Author	Revision
Closed	cedric	D10031 efl: improve Efl.Boolean_Model test to enforce Eina_Value type too.
Closed	cedric	D10030 ecore: remove unused piece of code.
Closed	cedric	D10029 ecore: properly initialize all field in event generated by Efl.Generic_Model
Closed	cedric	D10028 ecore: properly initialize the event structure in Efl.Generic_Model.
Closed	cedric	D9949 elementary: Efl.Ui.Widget_Factory bind widget property before finalizing the widget.
Closed	cedric	D9948 elementary: leverage sizing information from model if available to avoid unecessary calc.
Closed	cedric	D9947 efl_ui_position_manager: a way to announce new entities
Closed	cedric	D9946 elementary: properly shutdown and cleanup Efl.Ui.Position_Manager.
Closed	cedric	D9945 elementary: fix double eina_value_free in Efl.Ui.Homogeneous_Model.property.set
Closed	cedric	D9944 ecore: remove unused variable after code migration. Fix warning.
Closed	cedric	D9943 eina: prevent leak of Eina_Value internal allocation.
Closed	cedric	D9942 eina: add code to help debug leaking Eina_Value.
Closed	cedric	D9941 eina: add eina_mempool_iterator_new to slowly iterate every allocated pointer in a mempool.
Closed	cedric	D9940 eina: turn on Eina_Mempool tests for OneBig too.
Closed	cedric	D9939 eina: fix free support in eina OneBig mempool.
Closed	cedric	D9938 eina: fix eina_mempool_from to not report pointer that have never been allocated as allocated.