Page MenuHomePhabricator

efl_ui_position_manager: a way to announce new entities
ClosedPublic

Authored by cedric on Sun, Sep 15, 11:37 PM.

Details

Summary

there are situations where the entity is not ready yet when the initial
placing does happen. With this API you can tell the position manager
that the placing of the items can be reapplied at the entities are
availble now.

Depends on D10033

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
cedric created this revision.Sun, Sep 15, 11:37 PM

I would say this looks fine ... but i am the author :-D

zmike requested changes to this revision.Mon, Sep 16, 6:17 AM

pls run your code through spellcheck before submitting

src/lib/elementary/efl_ui_position_manager_entity.eo
95

their

This revision now requires changes to proceed.Mon, Sep 16, 6:17 AM

It seems phab doesn't preserve the git author. It should be correct in the branch I pushed and we should land from there.

cedric updated this revision to Diff 25190.Thu, Sep 19, 1:14 PM
cedric edited the summary of this revision. (Show Details)

rebase and take comment into account.

zmike resigned from this revision.Thu, Sep 19, 1:43 PM
This revision was not accepted when it landed; it landed in state Needs Review.Thu, Sep 19, 2:42 PM
Closed by commit rEFLfc935e99d936: efl_ui_position_manager: a way to announce new entities (authored by Marcel Hollerbach <mail@marcel-hollerbach.de>, committed by cedric). · Explain Why
This revision was automatically updated to reflect the committed changes.

I do not understand how this commit has landed when you say "Depends on D10033" which is still being reviewed.
If build didn't break, this means this patch didn't really depend on the other one, right?
Building the right patch dependency tree would simplify reviewing and generate less phab mail flood...