Differential D9951

elementary: Efl.Ui.Layout_Factory bind property during widget creation.
ClosedPublic
Actions

Authored by cedric on Sep 15 2019, 11:38 PM.

Tags

Subscribers

reviewers, committers

Details

Reviewers

zmike
stefan_schmidt
bu5hm4n
SanghyeonLee
lauromoura
felipealmeida
segfaultxavi

Maniphest Tasks

T8177: Collection_View Tracking ticket

Commits

rEFL3c0b496ad342: elementary: Efl.Ui.Layout_Factory bind property during widget creation.

Summary

In the same vain as previous patch this will initialize more of the widget during its
creation and reduce unecessary recalc.

Depends on D9950

Diff Detail

Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

cedric created this revision.Sep 15 2019, 11:38 PM

Herald added subscribers: committers, reviewers. · View Herald TranscriptSep 15 2019, 11:38 PM

cedric requested review of this revision.Sep 15 2019, 11:38 PM

cedric added a child revision: D9952: efl: split Efl.Ui.Factory.create stage into constructing and building.

Harbormaster completed remote builds in B13303: Diff 25021.Sep 15 2019, 11:42 PM

bu5hm4n accepted this revision.Sep 16 2019, 12:41 AM

This revision is now accepted and ready to land.Sep 16 2019, 12:41 AM

zmike requested changes to this revision.Sep 16 2019, 6:25 AM

zmike added inline comments.

src/lib/elementary/efl_ui_layout_factory.c
82–83	Use unified API.
83	This should probably be `efl_gfx_hint_fill_set`

This revision now requires changes to proceed.Sep 16 2019, 6:25 AM

rebase and take comment into account

Harbormaster completed remote builds in B13419: Diff 25194.Sep 19 2019, 1:15 PM

bu5hm4n accepted this revision.Sep 20 2019, 12:31 AM

rebase

Harbormaster completed remote builds in B13472: Diff 25275.Sep 20 2019, 3:19 PM

phab!!!

Harbormaster completed remote builds in B13481: Diff 25284.Sep 20 2019, 3:23 PM

bu5hm4n accepted this revision.Sep 23 2019, 7:53 AM

rebase and take comments into account.

Harbormaster completed remote builds in B13561: Diff 25411.Sep 23 2019, 4:10 PM

it seems okay to me.

bu5hm4n accepted this revision.Sep 23 2019, 11:56 PM

This revision was not accepted when it landed; it landed in state Needs Review.Sep 24 2019, 12:19 AM

Closed by commit rEFL3c0b496ad342: elementary: Efl.Ui.Layout_Factory bind property during widget creation. (authored by cedric, committed by Marcel Hollerbach <mail@marcel-hollerbach.de>). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			src/lib/elementary/efl_ui_layout_factory.c (37 lines)
M			src/lib/elementary/efl_ui_layout_factory.eo (1 line)

Diff 25439

src/lib/elementary/efl_ui_layout_factory.c

Loading...

src/lib/elementary/efl_ui_layout_factory.eo

Loading...