Page MenuHomePhabricator
Differential D9956

elementary: factorize all events emitted by a Efl.Ui.Collection into their own interface.
ClosedPublic
Actions

Authored by cedric on Sep 15 2019, 11:39 PM.

Details

Reviewers
zmike
stefan_schmidt
bu5hm4n
SanghyeonLee
lauromoura
felipealmeida
segfaultxavi
Maniphest Tasks
T8177: Collection_View Tracking ticket
Commits
rEFL1c0916ef0354: elementary: factorize all events emitted by a Efl.Ui.Collection into their own…
Summary

For most event it is actually meaningful to share them with Efl.Ui.Collection_View so let's do it.

Depends on D9955

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
cedric created this revision.Sep 15 2019, 11:39 PM
bu5hm4n requested changes to this revision.Sep 16 2019, 1:11 AM
bu5hm4n added inline comments.
src/lib/elementary/efl_ui_collection.eo
7

I do not want to nitpick because of every little bla, but this is making me cry :-D

This revision now requires changes to proceed.Sep 16 2019, 1:11 AM
segfaultxavi added a comment.Sep 16 2019, 4:25 AM

If you're talking about the indentation, I created a new macro just for you, @cedric:

Macro flammenwerfer:

zmike requested changes to this revision.Sep 16 2019, 6:42 AM

Macro 50s_facepalm:

cedric planned changes to this revision.Sep 17 2019, 8:27 PM
cedric updated this revision to Diff 25199.Sep 19 2019, 1:16 PM
cedric edited the summary of this revision. (Show Details)

rebase and take comments into account

cedric updated this revision to Diff 25289.Fri, Sep 20, 3:24 PM

phab!!!

cedric updated this revision to Diff 25416.Mon, Sep 23, 4:12 PM

rebase and take comment into account5~

SanghyeonLee requested changes to this revision.Mon, Sep 23, 7:43 PM
SanghyeonLee added inline comments.
src/lib/elementary/efl_ui_collection.eo
7

still it looks broken

This revision now requires changes to proceed.Mon, Sep 23, 7:43 PM
This revision was not accepted when it landed; it landed in state Needs Revision.Tue, Sep 24, 11:13 AM
Closed by commit rEFL1c0916ef0354: elementary: factorize all events emitted by a Efl.Ui.Collection into their own… (authored by cedric). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 25459

View Options

src/lib/elementary/Efl_Ui.h

Loading...
View Options

src/lib/elementary/efl_ui_collection.eo

Loading...
View Options

src/lib/elementary/efl_ui_collection_events.eo

Loading...
View Options

src/lib/elementary/efl_ui_item.c

Loading...
View Options

src/lib/elementary/meson.build

Loading...