This interface is currently focusing on being use by widget like
Efl.Ui.Collection_View or Efl.Ui.Select_Model. I have decided that
it should not be available along with Efl.Ui.Multi_Selectable.
Depends on D9956
Details
Details
Diff Detail
Diff Detail
- Repository
- rEFL core/efl
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
| src/lib/elementary/efl_ui_multi_selectable_async.eo | ||
|---|---|---|
| 6 | Interface for getting access to a range of selected items for widgets that provide them asynchronously. | |
| 8 | Better use @Efl.Ui.Selectable than just Selectables, no? | |
| 28 | Use $a and $b instead of a and b, for clarity (and don't miss any!). | |
| 29 | the range of the widget. | |
Comment Actions
minor nit
| src/lib/elementary/efl_ui_select_model.c | ||
|---|---|---|
| 570 | Shouldn't this leave the last-selected item still selected? | |
Comment Actions
selected_get collide in mono as it has same name GetSelected for interator and boolean(though I don't know why function overloading is not working on this case...)
we already have selected_items_get for iterator of selected children,
so I think simply we remove selected_get on the select_model,
and change name unselected_get to unselected_items_get for unity of method.
| src/lib/elementary/efl_ui_multi_selectable_async.eo | ||
|---|---|---|
| 34 | I think... the range is common feature that can used everywhere, the necessity of Eina.Range structure is, though I think it may hard to implement this on our release... so then we have to compromise current way.. | |
Comment Actions
Still ... using ... EFL_UI_SELECT_MODE_SINGLE_ALWAYS ... (which is not there anymore)