Depends on D9958
Details
Details
Diff Detail
Diff Detail
- Repository
- rEFL core/efl
- Branch
- T8177-devs/cedric/cv-finalize
- Lint
Lint OK - Unit
No Unit Test Coverage - Build Status
Buildable 13311
Comment Actions
I am super happy with this one.
But can you add a test to elm_test and not just examples ? examples are likely to not be really tested, elm_test is the standard way of adding widgets...
| src/examples/elementary/efl_ui_list_view_example_3.c | ||
|---|---|---|
| 123 | Why is that commented out ? | |
Comment Actions
More testing:
- ./src/examples/elementary/efl_ui_list_view_example_2 does not work anymore
- ./src/examples/elementary/efl_ui_list_view_example_3 segfaults after pressing Add Item
Comment Actions
seems it missing to delete removed file list in Elementary.h
if Efl_Ui.h is right place for new widget set,
list_view.eo.h also need to replaced to Efl.Ui.h
Comment Actions
Because of 1aeef0434e5ac788c69d8c4ca4af7bddac5ad4dc .
- ./src/examples/elementary/efl_ui_list_view_example_3 segfaults after pressing Add Item
Indeed. Looking at it and fixed that, will try to push an update in my branch tonight, but I am seeing an issue the position manager is not relayouting the widget when an item is added/removed inside the view port and I am not to sure of the strategy to fix this.
Comment Actions
For whatever reason git phab decided to create a new patch instead of updating this one and for further review, please look at D10035.