Differential D9960

elementary: add Efl.Ui.Grid_View by leveraging MVVM and Collection/Position_Manager infrastructure.
ClosedPublic
Actions

Authored by cedric on Sep 15 2019, 11:39 PM.

Tags

Subscribers

reviewers, committers

Details

Reviewers

zmike
stefan_schmidt
bu5hm4n
SanghyeonLee
lauromoura
felipealmeida
segfaultxavi

Maniphest Tasks

T8177: Collection_View Tracking ticket

Commits

rEFL5096cd32ad58: elementary: add Efl.Ui.Grid_View by leveraging MVVM and…

Summary

Co-authored-by: Marcel Hollerbach <mail@marcel-hollerbach.de>

Depends on D10035

Diff Detail

Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

cedric created this revision.Sep 15 2019, 11:39 PM

Herald added subscribers: committers, reviewers. · View Herald TranscriptSep 15 2019, 11:39 PM

cedric requested review of this revision.Sep 15 2019, 11:39 PM

Harbormaster completed remote builds in B13312: Diff 25030.Sep 15 2019, 11:42 PM

Can we get a test case in elm_test ?

bu5hm4n added a child revision: D9969: efl_ui_collection_view: support focus.Sep 16 2019, 5:19 AM

gonna need that elm_test case

This revision now requires changes to proceed.Sep 16 2019, 6:52 AM

need to add grid_view.eo.h in Efl_Ui.h

cedric planned changes to this revision.Sep 17 2019, 8:42 PM

Also add the .c file to the src of elementary.

bu5hm4n added inline comments.Sep 18 2019, 12:08 PM

src/lib/elementary/efl_ui_grid_view.c
20	_efl_ui_grid_view_efl_object_constructor

rebase and take comment into account

Harbormaster completed remote builds in B13429: Diff 25204.Sep 19 2019, 1:17 PM

You didn't take my comment into account.

This revision now requires changes to proceed.Sep 19 2019, 1:48 PM

phab!!!

Harbormaster completed remote builds in B13491: Diff 25294.Fri, Sep 20, 3:25 PM

cedric added a child revision: D10061: elementary: Efl.Ui.Select_Model should actually use iterator_new as prefix for all iterator functions..Fri, Sep 20, 3:25 PM

bu5hm4n requested changes to this revision.Sat, Sep 21, 2:55 AM

bu5hm4n added inline comments.

src/lib/elementary/meson.build
903	Now you added it twice.

This revision now requires changes to proceed.Sat, Sep 21, 2:55 AM

bu5hm4n removed a parent revision: D9959: elementary: migrate Efl.Ui.List_View to use Efl.Ui.Collection_View..Sat, Sep 21, 3:02 AM

bu5hm4n removed a child revision: D9969: efl_ui_collection_view: support focus.Mon, Sep 23, 7:42 AM

rebase and take comment into account

Harbormaster completed remote builds in B13571: Diff 25421.Mon, Sep 23, 4:21 PM

cedric added a child revision: D10063: elementary: add a basic test for MVVM infrastructure..Mon, Sep 23, 4:21 PM

This revision was not accepted when it landed; it landed in state Needs Review.Tue, Sep 24, 11:14 AM

Closed by commit rEFL5096cd32ad58: elementary: add Efl.Ui.Grid_View by leveraging MVVM and… (authored by cedric). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			src/lib/elementary/Efl_Ui.h (1 line)
M			src/lib/elementary/efl_ui_collection_view.eo (2 lines)
A	M		src/lib/elementary/efl_ui_grid_view.c (26 lines)
A	M		src/lib/elementary/efl_ui_grid_view.eo (17 lines)
M			src/lib/elementary/meson.build (2 lines)

Diff 25464

src/lib/elementary/Efl_Ui.h

Loading...

src/lib/elementary/efl_ui_collection_view.eo

Loading...

src/lib/elementary/efl_ui_grid_view.c

Loading...

src/lib/elementary/efl_ui_grid_view.eo

Loading...

src/lib/elementary/meson.build

Loading...