Page MenuHomePhabricator

eina: fix spelling in new eina_file_statgen API
ClosedPublic

Authored by stefan_schmidt on Sep 16 2019, 12:46 AM.

Details

Summary

Introduced in 9b294d6284f the new eina_file_statgen_* API has a typo in
its disable function. Fixing this before it gets out into a release.

Thanks goes to the https://abi-laboratory.pro service for offering their
great API/ABI reports to the open source communities to help finding such
things!

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

stefan_schmidt requested review of this revision.Sep 16 2019, 12:46 AM
vtorri added a subscriber: vtorri.Sep 16 2019, 1:10 AM

maybe this should have been detected with a unit test too, no ?

If there would be a unit test it could have helped to detect this. Such typos can find it way into various places though when the API call is simply copied from only file to another.
Reviewing APIs manually is always a good idea before a release. Machines can only understand some things that we wanted to be taken care of :-)

vtorri accepted this revision.Sep 16 2019, 2:53 AM
This revision is now accepted and ready to land.Sep 16 2019, 2:53 AM
raster accepted this revision.Sep 16 2019, 3:03 AM
This revision was automatically updated to reflect the committed changes.