Page MenuHomePhabricator

efl_ui_collection_view: support focus
ClosedPublic

Authored by bu5hm4n on Mon, Sep 16, 5:19 AM.

Details

Summary

with this commit you can more or less use focus. The only uncaught case
for now is that if the object is not available, no focus can be set.
Navigating with focus on the screen however should be possible.

Depends on D10063

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bu5hm4n created this revision.Mon, Sep 16, 5:19 AM

The question is, where do we store the property focus ?

zmike requested changes to this revision.Mon, Sep 16, 6:54 AM
zmike added a subscriber: zmike.
zmike added inline comments.
src/lib/elementary/efl_ui_collection_view.c
2257

safety?

2278–2279

safety?

2323

This case should probably just be deferred instead of erroring?

This revision now requires changes to proceed.Mon, Sep 16, 6:54 AM
bu5hm4n added inline comments.Mon, Sep 16, 7:23 AM
src/lib/elementary/efl_ui_collection_view.c
2257

what do you mean ?

2278–2279

what do you mean ?

2323

I would love to do that, but i do not know how, since i do not know how to preserve correct focus flags over, since there is no point where we are storing the focus flag.

cedric added inline comments.Tue, Sep 17, 6:35 PM
src/lib/elementary/efl_ui_collection_view.c
2323

Maybe it make sense to prevent the destruction of the item that has focus and also keep around the last item of the collection in case we need it for focus purpose. Wouldn't that solve your problem?

bu5hm4n added inline comments.Wed, Sep 18, 7:57 AM
src/lib/elementary/efl_ui_collection_view.c
2323

Sadly not. lets say you focus element 400 in a range of 1000 items. and now press down, you will find the item 401 beeing needed, but not beeing available.

I have a idea for this, but that needs some further discussion, can we do that once this is merged ? (I feel like we are backing up a lot of work)

zmike added inline comments.Thu, Sep 19, 1:47 PM
src/lib/elementary/efl_ui_collection_view.c
2257

Use a safety check to print an error automatically for this case?

2278–2279

Use a safety check to print an error automatically for this case?

bu5hm4n marked 6 inline comments as done.Tue, Sep 24, 1:23 AM
bu5hm4n added inline comments.
src/lib/elementary/efl_ui_collection_view.c
2278–2279

The above case is now with a macro, which means, no error needed here.

bu5hm4n updated this revision to Diff 25444.Tue, Sep 24, 1:24 AM
bu5hm4n marked an inline comment as done.
bu5hm4n edited the summary of this revision. (Show Details)

be safe

This revision was not accepted when it landed; it landed in state Needs Review.Tue, Sep 24, 11:14 AM
Closed by commit rEFLb057ac1af641: efl_ui_collection_view: support focus (authored by Marcel Hollerbach <mail@marcel-hollerbach.de>, committed by cedric). · Explain Why
This revision was automatically updated to reflect the committed changes.