Page MenuHomePhabricator

efl_ui/win: fix prototype decls for eo api versions of autodel
ClosedPublic

Authored by zmike on Mon, Sep 16, 12:32 PM.

Details

Summary

this is still pretty broken, but at least the headers aren't
Depends on D9971

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
zmike created this revision.Mon, Sep 16, 12:32 PM
zmike requested review of this revision.Mon, Sep 16, 12:32 PM
stefan_schmidt added inline comments.Tue, Sep 17, 7:01 AM
src/lib/elementary/Efl_Ui.h
221

You dropped the inline for both of these compared to the old state. Any particular reason for this?

zmike added inline comments.Tue, Sep 17, 7:08 AM
src/lib/elementary/Efl_Ui.h
221

Generally speaking we don't inline API functions which are in .c files; that's only in .x files.

stefan_schmidt accepted this revision.Tue, Sep 17, 7:34 AM
stefan_schmidt added inline comments.
src/lib/elementary/Efl_Ui.h
221

Well, the old one was not a .x file either. I don't really mind, though. Just wanted to raise this durign review in case this was not intentional to drop it.

This revision is now accepted and ready to land.Tue, Sep 17, 7:34 AM
zmike added inline comments.Tue, Sep 17, 7:41 AM
src/lib/elementary/Efl_Ui.h
221

True, but it was still in a file that was included, and it was static inline. There's no way to keep this function in a header since it mixes unified and legacy APIs, so I changed it to not be inline.

Closed by commit rEFLffac7f076f26: efl_ui/win: fix prototype decls for eo api versions of autodel (authored by zmike, committed by Marcel Hollerbach <mail@marcel-hollerbach.de>). · Explain WhyWed, Sep 18, 9:05 AM
This revision was automatically updated to reflect the committed changes.