Page MenuHomePhabricator

efl_ui_layout_part_table: implement Efl.Pack.pack API
ClosedPublic

Authored by bu5hm4n on Sep 17 2019, 8:16 AM.

Details

Summary

this api was missing, the pack method here is behaving in the same
manner as Efl.Ui.Table.

Depends on D9991

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bu5hm4n created this revision.Sep 17 2019, 8:16 AM
bu5hm4n requested review of this revision.Sep 17 2019, 8:16 AM
zmike requested changes to this revision.Sep 17 2019, 9:39 AM

I'm really not sure we want to be directly manipulating the internals of edje parts. cc @cedric here for additional thinking

src/lib/elementary/efl_ui_layout_pack.c
290

This is never freed.

This revision now requires changes to proceed.Sep 17 2019, 9:39 AM
bu5hm4n updated this revision to Diff 25101.Sep 17 2019, 10:13 AM
bu5hm4n edited the summary of this revision. (Show Details)

free correctly, and use _efl ui layout API

cedric accepted this revision.Sep 19 2019, 1:48 PM
This revision was not accepted when it landed; it landed in state Needs Review.Sep 19 2019, 2:41 PM
Closed by commit rEFLaecb3a4bb27e: efl_ui_layout_part_table: implement Efl.Pack.pack API (authored by Marcel Hollerbach <mail@marcel-hollerbach.de>, committed by cedric). · Explain Why
This revision was automatically updated to reflect the committed changes.