Page MenuHomePhabricator

There should only be one dialog affecting the Desk Change animation…
Open, TrivialPublic

Description

Right now, there are two separate Settings dialogues that affect Desk Change.

One of those is in Settings > Look > Transitions > Desk Change, the second is in Screen > Virtual Desktops > Flip Animation.

Kinda fun though, you can mix and match.

...I like this. I vote that we keep it.

abyomi0 created this task.Aug 17 2014, 5:59 PM
abyomi0 updated the task description. (Show Details)
abyomi0 raised the priority of this task from to Pending on user input.
abyomi0 added a project: enlightenment-git.
abyomi0 changed the visibility from "All Users" to "Public (No Login Required)".
abyomi0 added a subscriber: abyomi0.
abyomi0 edited this Maniphest Task.Aug 17 2014, 6:00 PM
abyomi0 updated the task description. (Show Details)Nov 18 2014, 3:36 PM
abyomi0 raised the priority of this task from Pending on user input to Trivial.Jul 18 2015, 3:00 PM
shorne added a subscriber: shorne.Nov 7 2015, 4:24 AM

Just to make things a bit more clear. This is basically a usability issue.

The Settings > Look Transitions > Desk Change setting affects the background transition when a desk is changed. The code is in conf_theme/e_int_config_transitions.c. The configured transitions (ie crossfade, vswipe) are parts of the theme which are stored at e/transitions.

The Screen > Virtual Desktops > Flip Animation settings affect how the windows move/react when a desk is changed. The code is in conf_display/e_int_config_desks.c. The available animations are also part of the theme stored at e/comp/effects/auto.

I think it does make sense to put these all in one place from a usability perspective. Maybe move Desktop Flip Animation to Transition Settings and have a nice window transition preview? But one is for Background, one is for Window right now so it technically makes sense as is.