Page MenuHomePhabricator

Shortcut for Setting title of tab wont work properly
Closed, InvalidPublic

Description

The bug is related to create a new tab (ctl-alt-t) and then immediately set the title using ctrl-t. Sometime, you'll notice Terminology would set the title of the old tab, instead of the newly created tab. The patch below fixes this bug. However, Boris insists that the said patch is not proper (ref. https://github.com/billiob/terminology/issues/43 ). Someone please review this the patch or help fix the issue. thank you.

Pham

diff --git a/src/bin/win.c b/src/bin/win.c
index df3c234..43a0f3d 100644
--- a/src/bin/win.c
+++ b/src/bin/win.c
@@ -2389,7 +2389,7 @@ _tab_new_cb(void *data,
    /* XXX: need to refresh */
    tc_parent->swallow(tc_parent, tc, tc);

-   if (tc->is_focused)
+   if (tc->is_focused==EINA_FALSE)
      tc_new->focus(tc_new, tc);

    _tabs_refresh(tabs);
tpham3783 updated the task description. (Show Details)
billiob triaged this task as Pending on user input priority.Nov 20 2016, 11:14 AM

@tpham3783 is it still the case?

billiob closed this task as Invalid.Feb 25 2018, 8:16 PM