Page MenuHomePhabricator

Terminology broken tab after change in edje table/box handling
Closed, ResolvedPublic

Description

After commit 58d0c89fd9513e61ff2633c8947be326f194ff87 and a long git bisect, in terminology with the option "Show tab" set, the first tab created with a key shortcut (Usually Ctrl+T) doesn't show until we right click and get the context menu to display. This wasn't a problem before the box/table change.

cedric created this task.Jul 25 2016, 4:15 PM
jpeg added a comment.Jul 25 2016, 6:40 PM

I'll have a look. Another major issue I quickly found in testing your scenario is the following:

  • Open terminology
  • Ctrl+Shift+T to open new tab
  • Wait a few sec (maybe change focussed window)
  • Ctrl+Shift+T to open new tab

Terminology (EFL) is then going to loop somewhere in edje_calc, encounter a lot of dead objects, and possibly SEGV.

jpeg added a comment.Jul 25 2016, 11:31 PM

Ok. After many rebuilds, I can conclude that the offending commit is not 58d0c89fd9513e61ff2633c8947be326f194ff87 but instead its parent: 99924852abf4e92db329d2f9f89a43a3143eea0d. That bisect must have been painful. So far I have no idea what's going wrong, no idea despite a lot of printf. Will keep investigating... :)