Page MenuHomePhabricator

elm_image: New API elm_image_sizing_eval should not exist
Closed, ResolvedPublic

Description

The EAPI elm_image_sizing_eval was wrongfully added and marked as since 1.7 when in fact it was an EO-only internal function.
See beb6fa61c7a3939eb3df50c31e20079801b00219.
Should we remove it before making an annoucement for 1.18.1? Or just mark as deprecated?

I don't like this... Have an ABI break between the un-announced 1.18.0 and 1.18.1 or have an internal function exposed? (It can do nothing in the future... but it means an extra symbol at the very least).

efl 1.18.0 still isnt announced on e.org...

it's nowhere in sight as far as the world cares... so remove it before we push out 1.18.0 (it has to be announced, e.org links pointed to it etc. - until then it's not a release...)

jpeg added a comment.Aug 11 2016, 4:20 PM

OK. I wonder if the other new legacy APIs should also be removed then:

elm_image_fill_inside_get ( Evas_Object const* obj )
elm_image_fill_inside_set ( Evas_Object* obj, Eina_Bool fill_inside )
elm_image_resize_down_get ( Evas_Object const* obj )
elm_image_resize_down_set ( Evas_Object* obj, Eina_Bool resize_down )
elm_image_resize_up_get ( Evas_Object const* obj )
elm_image_resize_up_set ( Evas_Object* obj, Eina_Bool resize_up )
elm_image_scale_get ( Evas_Object const* obj )
elm_image_scale_set ( Evas_Object* obj, double scale )
elm_image_sizing_eval ( Evas_Object* obj )

In particular:

elm_image_resize_down_get ( Evas_Object const* obj )
elm_image_resize_down_set ( Evas_Object* obj, Eina_Bool resize_down )
elm_image_resize_up_get ( Evas_Object const* obj )
elm_image_resize_up_set ( Evas_Object* obj, Eina_Bool resize_up )
elm_image_sizing_eval ( Evas_Object* obj )

Since the resize ones are redundant with resizable. The two others are just exposing new features.

kuuko added a subscriber: kuuko.Aug 11 2016, 4:27 PM