Page MenuHomePhabricator

GTK menus broken as hell
Closed, ResolvedPublic

Description

Many issues.

First:
Open a GTK app (ie transmission) > Click on File > Click outside the window to open the menu > Nothing happens (it also seems to affect the ability to take screenshots with print screen)

Second:
Open a GTK app > Move the window outside the screen limits (left or right side) > and move the pointer from file to edit (or whatever is visible) > See it act weird. (not able to move the pointer, menus being sized wrong and a shit load of weirdness)

Third:
Open GTK app > Open a terminology win > Move it over the gtk one so you can see the menus > Focus the GTK > Click File > Focus terminology > Move from file to Edit.> You move through the menu of a non focused window. (Weston doesn't behave like that even thoug there you have to click two times to focus term -one to close the menu two to focus-. Best would be IMO clicking on term closes the menu and focuses the win)

ApB created this task.Nov 30 2016, 9:08 AM
ApB added a subscriber: ManMower.Dec 1 2016, 3:06 AM

Update. Commits by @ManMower probably fixed some issues yet some remain.

First.
Now clicking outside the window to close the menu turns the pointer into a resize one which if you click and drag it resizes the window. WTF. (printscreen an other input -ie alt+tab- still fucked up)

Second.
Doesn't act as weird anymore however menus are sized wrong still

Third.
Clicking outside the window you end up with the first bug so yeah.

Bonus.
On occasion menus are placed all over the screen and not where they belong but can't find a reliable way of reproducing this :/

Additional Bonus
if you place a gtk win on the lower portion of the screen -in a way where all the menu won't fit- and open a menu the contents appear on top. Weston renders them outside the screen. No idea which is supposed to be the correct behavior.

zmike added a comment.Dec 1 2016, 8:25 AM
In T4939#77119, @ApB wrote:

Update. Commits by @ManMower probably fixed some issues yet some remain.

First.
Now clicking outside the window to close the menu turns the pointer into a resize one which if you click and drag it resizes the window. WTF. (printscreen an other input -ie alt+tab- still fucked up)

  1. the input grabbing is required by spec; the window grabs all input until the menu is dismissed, meaning that bindings must be disabled too

Second.
Doesn't act as weird anymore however menus are sized wrong still

this is how the spec works. it's stupid but not a compositor bug

Third.
Clicking outside the window you end up with the first bug so yeah.

Bonus.
On occasion menus are placed all over the screen and not where they belong but can't find a reliable way of reproducing this :/

probably also a spec issue

Additional Bonus
if you place a gtk win on the lower portion of the screen -in a way where all the menu won't fit- and open a menu the contents appear on top. Weston renders them outside the screen. No idea which is supposed to be the correct behavior.

our behavior is correct, weston is broken

ApB added a comment.Dec 1 2016, 10:26 AM
In T4939#77226, @zmike wrote:
In T4939#77119, @ApB wrote:

Update. Commits by @ManMower probably fixed some issues yet some remain.

First.
Now clicking outside the window to close the menu turns the pointer into a resize one which if you click and drag it resizes the window. WTF. (printscreen an other input -ie alt+tab- still fucked up)

  1. the input grabbing is required by spec; the window grabs all input until the menu is dismissed, meaning that bindings must be disabled too

And how are you supposed to take a screenshot with a menu open?

Second.
Doesn't act as weird anymore however menus are sized wrong still

this is how the spec works. it's stupid but not a compositor bug

Tried the same thing on weston (move win outside the screen limits until half the word File appears on the screen and click it) and works fine there. E on the other hand opens a menu that takes up the whole width of the screen. Looks more broken in E than in weston regardless of who implements the spec right.

Third.
Clicking outside the window you end up with the first bug so yeah.

Bonus.
On occasion menus are placed all over the screen and not where they belong but can't find a reliable way of reproducing this :/

probably also a spec issue

(͡° ͜ʖ ͡°)

Additional Bonus
if you place a gtk win on the lower portion of the screen -in a way where all the menu won't fit- and open a menu the contents appear on top. Weston renders them outside the screen. No idea which is supposed to be the correct behavior.

our behavior is correct, weston is broken

(͡° ͜ʖ ͡°) no.2