Page MenuHomePhabricator

E crashing on "Exit" "Restart" "Desktop Icon" w/tasks
Closed, ResolvedPublic

Description

This does not take long to reproduce:

  1. Start E
  2. Click on menu to show it.
  3. Click "Exit"
  4. Crash

or

  1. Start E
  2. Click on a desktop icon
  3. Crash

here is the bt:

This is happening on "Exit" "Restart" "Clicking a desktop icon"...A lot

#0  _thread_sys_sigsuspend () at /usr/src/lib/libc/arch/amd64/sys/sigsuspend.S:45
#1  0x00000a9588bbeb77 in *_libc_sigsuspend_cancel (set=Variable "set" is not available.
) at /usr/src/lib/libc/sys/w_sigsuspend.c:35
#2  0x00000a9588bdb2a8 in pause () at /usr/src/lib/libc/gen/pause.c:19
#3  0x00000a92e3297b02 in e_alert_show () at src/bin/e_alert.c:43
#4  0x00000a92e32411e2 in _e_crash () at src/bin/e_signals.c:117
#5  0x00000a92e324126c in e_sigbus_act (x=10, info=0x7f7ffff86150, data=0x7f7ffff86060)
    at src/bin/e_signals.c:157
#6  0x00000a9518ddf8ea in _eina_mmap_safe_sigbus (sig=10, siginfo=0x7f7ffff86150, ptr=0x7f7ffff86060)
    at lib/eina/eina_mmap.c:110
#7  <signal handler called>
#8  0x00000a92e313ac6f in e_client_icon_add (ec=0x4000000276ceaf65, evas=0x40000000aecea5b9)
    at src/bin/e_client.c:5018
#9  0x00000a95681db0cf in _tasks_item_fill (item=0xa952197a100) at src/modules/tasks/e_mod_main.c:697
#10 0x00000a95681dab32 in _tasks_item_new (tasks=0xa955a582e40, ec=0xa94fe7ad800)
    at src/modules/tasks/e_mod_main.c:576
#11 0x00000a95681dac80 in _tasks_item_add (tasks=0xa955a582e40, ec=0xa94fe7ad800)
    at src/modules/tasks/e_mod_main.c:604
#12 0x00000a95681dac51 in _tasks_item_check_add (tasks=0xa955a582e40, ec=0xa94fe7ad800)
    at src/modules/tasks/e_mod_main.c:595
#13 0x00000a95681da3ef in _tasks_refill (tasks=0xa955a582e40) at src/modules/tasks/e_mod_main.c:420
#14 0x00000a95681da67c in _tasks_refill_all () at src/modules/tasks/e_mod_main.c:480
#15 0x00000a95681dbddf in _tasks_cb_event_client_add (data=0x0, type=188, event=0xa9523bdc200)
    at src/modules/tasks/e_mod_main.c:943
#16 0x00000a9563e4f1f5 in _ecore_call_handler_cb (func=0xa95681dbc8b <_tasks_cb_event_client_add>, data=0x0, 
    type=188, event=0xa9523bdc200) at ecore_private.h:317
#17 0x00000a9563e50183 in _ecore_event_call () at lib/ecore/ecore_events.c:518
#18 0x00000a9563e58b1b in _ecore_main_loop_iterate_internal (once_only=0) at lib/ecore/ecore_main.c:2368
#19 0x00000a9563e56adc in ecore_main_loop_begin () at lib/ecore/ecore_main.c:1288
#20 0x00000a92e310ab1b in main (argc=1, argv=0x7f7ffffbf938) at src/bin/e_main.c:1093
The program is running.  Quit anyway (and detach it)? (y or n) Detaching from program: /usr/local/opt/bin/enlightenment, process 21796

Related Objects

netstar created this task.Dec 20 2016, 6:42 AM

As usual X11 on OpenBSD (amd64). Git master (E/EFL) I noticed 3 new commits to enlightenment.git which might be suspect?

netstar triaged this task as Showstopper Issues priority.Dec 20 2016, 6:43 AM

I reverted the last few commits with:

git reset --hard 001e08c54aafc891df36c5c941162ded0a666a14

and E is working.

With this it only happens when the tasks module is loaded.

+   ec = e_client_stack_active_adjust(item->client);

ec is being accessed before it's given a value. in

else
 ittem->o_icon = e_clent_icon_add(ec....
`

BOOM?