Page MenuHomePhabricator

Refactor toolbar
Open, WishlistPublic

Description

Toolbar should become some kind of container like popup (T5326), provide the same mixin for helping creating items with string, icon and associated data to it.

thiepha claimed this task.Apr 11 2017, 6:23 PM

@cedric Do you think this "making mixin" is something for all widget classes that includes various items in it ?
Then, we need to think about the new title for this task.

jpeg reassigned this task from thiepha to cedric.Jun 14 2017, 6:26 PM
jpeg added a subscriber: thiepha.

@cedric should make one example of a non-model factory

cedric raised the priority of this task from TODO to High.Jul 10 2017, 3:39 PM

@cedric
I want to know the progress of this work - with simple factory thing together.

cedric lowered the priority of this task from High to TODO.Jan 11 2018, 3:45 PM

We are looking into using pager instead of toolbar in Tizen, there is no rush in implementing this one anymore.

cedric lowered the priority of this task from TODO to Wishlist.Jan 11 2018, 3:46 PM
zmike edited projects, added Restricted Project; removed efl.Jun 11 2018, 6:58 AM
segfaultxavi edited projects, added efl: widgets; removed Restricted Project.Jun 11 2018, 8:27 AM

Tab_Bar is pretty much what this is ... so i think this is done ?

Here a little RFC:

  • for a toolbar we do not need any other code than what we have right now in Tab_Bar.
  • we likely want to have different themes for those two types of UIs?

How about this:

  • We move the implementation in Tab_Bar to something like Selectable_Item_Box or so (Which is a box, that can be scrolled in a useable manner, with items in it, the items can be selected, and the object is used as single_selectable thing)
  • We introduce Tab_Bar_Items, which have a tab_bar UI
  • We introduce Tool_Bar_Items, which have a tool bar UI
  • Toolbar as well as Tab_Bar inherit from Selectable_Item_Box, and just checks for the correct types of items.

This would be the way to implement that with the least overhead i think? What do you think ?