Page MenuHomePhabricator

Elm code crash on large files
Open, HighPublic

Description

Elm code seems to crash on large files. Downstream issue #4

Need to provide sample files for replicating crash/testing.

Tested same file in downstream issue with EFL 1.19.1. With EFL 1.19.1 it does not crash, but never opens, seems to hang or something. Need to debug further... Either way not resolved with 1.19.1 but some progress.

Can you please test with 1.20-beta2?

I think this has gotten worse with 1.20 beta3. Seems to hang ecrire on large files, and eventually oom and crash. After it eats up CPU and makes E and X pretty unresponsive. Also got a oom during compile of ecrire and same issue, and I haven't seen that before. Maybe something in ecrire, but only happens on large files. Seems like a race condition or something.

[ 5514.436492] Out of memory: Kill process 31865 (ecrire) score 913 or sacrifice child
[ 5514.436545] Killed process 31865 (ecrire) total-vm:8205212kB, anon-rss:7373692kB, file-rss:68kB, shmem-rss:0kB

[ 5712.743162] Out of memory: Kill process 3084 (ecrire) score 896 or sacrifice child
[ 5712.743182] Killed process 3084 (ecrire) total-vm:8066376kB, anon-rss:7235424kB, file-rss:0kB, shmem-rss:0kB
ApB added a comment.Jun 19 2018, 10:20 AM

@ajwillia.ms any updates on this?? It still remains the biggest issue with elm-code (at least when using it with on ecrire)

Files that open fast on a text edidor like l3afpad hang with ecrire.

ajwillia.ms reopened this task as Open.Jun 19 2018, 3:05 PM

I mentioned before but not on this ticket, so I'll add it for the record.

We need to get line wrapping sorted before returning to this ticket.
The reason is that this problem is due to an optimisation of "how long to make the content" having been removed.
If the work is done to re-introduce it and then line wrapping is added it will just break again.

The related ticket did list some improvements that were made so it's not as bad as it used to be.
That said if anyone else wants to patch it I could certainly accept the contribution.

ApB added a comment.Jun 19 2018, 3:09 PM

@ajwillia.ms Thanks. Is wrapping planed for 1.21??

zmike triaged this task as High priority.Jun 27 2018, 12:36 PM
zmike edited projects, added efl: widgets, Restricted Project; removed efl.