Page MenuHomePhabricator

ecore_wayland: check the feture of clipbord which can be added
Open, NormalPublic

Description

Below is the feature related with clipbord.

@devilhorns
if there are some feature cannot be added to opensource, please share that information.
and I added person who implement clipbord code into tizen, if you have any question , add comment.
@gwanglim @thiepha @slotus.lee
if you know the history related with the question, would you answer the question?

**1. support clipboard data only set feature.

  1. support 'tizen_clipboard' interface
  2. copy & paste selection type**

We have copy & paste and drag & drop selection types, but we cannot
distinguish between these two types when requesters receive data
from data ready event.
This patch adds a new enum to help selection requesters distinguish
between two selection types and have suitable actions for each type.

4.support multiple mime types
It is need to distinguish clipboard selection in cbhm

  1. add selection event to distinguish clipboard selection

Detail:

  1. support clipboard data only set feature.

ecore_wl_clipboard_data_only_set
_ecore_wl_cb_clipboard_data_only_allowed
https://review.tizen.org/gerrit/#/c/117268/

  1. support 'tizen_clipboard' interface

EAPI extern int ECORE_WL_EVENT_CLIPBOARD_DATA_SELECTED;
EAPI void ecore_wl_clipboard_show
EAPI void ecore_wl_clipboard_hide
_ecore_wl_cb_clipboard_data_selected
https://review.tizen.org/gerrit/#/c/89393/

  1. copy & paste selection type

typedef enum

			{	
			   ECORE_WL_SELECTION_CNP,	
			   ECORE_WL_SELECTION_DND	
			} Ecore_Wl_Selection_Type;

https://review.tizen.org/gerrit/#/c/84728/

  1. support multiple mime types

deliver mime type to data reading callback
https://review.tizen.org/gerrit/#/c/82952/

  1. add selection event to distinguish clipboard selection in cbhm

https://review.tizen.org/gerrit/#/c/78887/

jypark created this task.Jul 24 2017, 6:39 PM
jypark reassigned this task from jypark to devilhorns.
zmike added a comment.Jul 25 2017, 5:41 AM
  1. I don't know what this is.
  1. I don't know what this is.
  1. selection enum?

we cannot distinguish between these two types when requesters receive data from data ready event

Which event is this? I am confused by the need for an enum in this case since selections and dnd operations are completely separate:

  • one type of receive (selection) occurs when the client manually decides to accept a selection by calling ecore_wl2_offer_receive() on the return of ecore_wl2_dnd_selection_get()
  • the other receive (drag) occurs based on offer provided in the Ecore_Wl2_Event_Dnd_Drop event

It seems obvious to me which one is being used without the need for an enum here.

  1. "deliver mime type to data reading callback" there is no way to accept/request a selection without knowing the mime type that you are accepting?
  1. See Ecore_Wl2_Event_Seat_Selection

It seems like many of these requirements could be solved by reading elm_cnp.c?