Page MenuHomePhabricator

[Svace] For-while null body
Closed, ResolvedPublic

Description

When Body is omitted intentionally in 'for/while' statement, it shall contain null statement (';') and comment /*NULL*/

logload.c

875:

   ptr = (char *)buf + 4;
   long start_pointer = (long) ptr;
   end = (char *)ptr + blocksize;
   while ((ptr = log_block_event_realtime_read(thd, ptr, end, start_pointer, feedback)));
}

635:

_log_file_first_read(void *data, Ecore_Thread *thread)
{
   eina_evlog("+first_read", NULL, 0.0, NULL);
   In_Thread_Data *thd = (In_Thread_Data*) data;
   thd->thread = thread;
   while (log_block_info_first_read(thd));
   eina_evlog("-first_read", NULL, 0.0, "Log file first read success");

573:

      free(buf);
        return EINA_FALSE;
     }
   ptr = buf;
   long start_pointer = (long) ptr;
   end = (char *)ptr + blocksize;
   while ((ptr = log_block_event_first_read(thd, ptr, end, start_pointer, feedback)));
   free(buf);
}
Deepwarrior moved this task from Defects to 1.1 on the Profiling Viewer board.
Deepwarrior edited projects, added Profiling Viewer (1.1); removed Profiling Viewer.
Deepwarrior moved this task from Backlog to Doing on the Profiling Viewer (1.1) board.

Delayed until SVACE wouldn`t work.

NikaWhite moved this task from Backlog to Done on the Profiling Viewer (1.1) board.Nov 8 2017, 5:53 AM
NikaWhite closed this task as Resolved.Dec 26 2017, 8:52 AM