Page MenuHomePhabricator
Create Task
Maniphest T6330

ecore-con now leaks fds
Closed, ResolvedPublic
Actions

Description

I've noticed this since the efl-net rewrite, and it's gotten to be a real problem. On my desktop, I run a gadget that uses ecore-con to periodically make client connections and read some data. At some point, it became an issue where I would start getting errors that no more fds could be created because ecore-con was never closing them. Valgrind confirms that a huge number of fds are being leaked, all created from efl_net_socket4().

Details

Commits
D6481 / rEFL683cddf90c8b: ecore-con/legacy: kill server with DEL event if a dialer error occurs
zmike created this task.Nov 6 2017, 2:26 PM
barbieri added a comment.Nov 6 2017, 4:28 PM

do you know if the objects get deleted?

I'm pretty sure the objects have "close on destructor" set, thus they should be deleted. If they are not, either some bug with "close on destructor" or some bug in reference counting which let the object dangling...

raster added a comment.Nov 6 2017, 11:41 PM

i've noticed writing a server runs into eo object and other ERR issues too... :/ ?

zmike added a comment.Nov 7 2017, 8:38 AM
In T6330#104055, @barbieri wrote:

do you know if the objects get deleted?

I'm pretty sure the objects have "close on destructor" set, thus they should be deleted. If they are not, either some bug with "close on destructor" or some bug in reference counting which let the object dangling...

I don't know.

zmike edited projects, added Restricted Project; removed efl.Jun 11 2018, 6:51 AM
zmike edited projects, added efl: networking; removed Restricted Project.Jun 11 2018, 8:47 AM
zmike claimed this task.Jun 29 2018, 7:30 AM
zmike added a subscriber: barbieri.

Behavior has been broken with the rewrite: servers no longer automatically disconnect when an error occurs. This is the cause of this ticket.

Fixing...