Page MenuHomePhabricator

Cleanup indicator APIs in slider.
Closed, ResolvedPublic

Description

Questions, based on efl_ui_slider.eo:

methods {

@property indicator_show { (bool) }
@property indicator_show_on_focus { (bool) }
@property step { ... }
@property indicator_visible_mode { (Efl.Ui.Slider.Indicator_Visible_Mode) }

}
parts {

indicator: Efl.Ui.Slider.Part; [[A floating indicator above the slider.]]

}

So why do we have a part and then 3 API's that contain the word indicator?
Also, why is it "show" and then "visible_mode"? show is not a noun, is it?

Looks like the answer is to have a single enum for EO API, which is slightly different from the legacy:

default
always
none
on_focus
on_drag (new in eo as it's "default" in legacy)

Bbut default here should mean "whatever is in elm_config".