Page MenuHomePhabricator

fp
Closed, ResolvedPublic

Description

eina_fp_mul: 0.40166s
eina_fp_div: 0.49111s

Related Objects

StatusAssignedTask
OpenNone
OpenNone
OpenNone
Resolvedcedric
zmike created this task.Mar 30 2018, 11:53 AM
zmike triaged this task as TODO priority.

Hum, the goal of the test is to test side effect and if there is any major deviation from the expected value. Maybe testing with larger, more random and fewer step is good enough.

zmike added a comment.Mar 30 2018, 1:37 PM

What do you mean by 'larger' in this case?

zmike added a comment.Mar 30 2018, 2:08 PM

Hm well changing to:

step1 = 0.007;
step2 = 0.061;

yields significant performance increases while providing the same coverage. Seems good enough.

sounds like a good solution to me too.

zmike added a subscriber: vtorri.Apr 2 2018, 12:32 PM

I asked @vtorri about it, will probably merge this for now to improve speed on a known-functional component and then update at a later point after a deeper review has been done.