Maniphest T6966

fix part namespacing in default theme
Closed, ResolvedPublic
Actions

Tags

Subscribers

vtorri, conr2d, woohyun and 5 others

Assigned To

segfaultxavi

Authored By

zmike, May 25 2018

Description

There are many, many issues with the default theme where parts and signals are not correctly namespaced. This must be resolved asap to avoid shipping a release which contains new theme groups that are incorrectly namespaced.

Details

Differential Revisions: D6459: default theme: fix group names in music_control
D6457: default theme: fix part names in elm/ews
Commits: D6462 / rEFLc42a7b6bfe61: default theme: fix part names in dialog
D6463 / rEFLcf23ec291d04: default theme: fix part names in notification
D6460 / rEFL17476212e59d: default theme: fix part names in systray
D6461 / rEFL97c51a670157: default theme: fix part names in illume
D6458 / rEFLcc4aff8640cf: default theme: fix group names in fileman
D6456 / rEFLc35214ee9c4a: default theme: fix part names in elm/scrollable/panel
D6455 / rEFL4d639df001ba: default theme: fix part names in elm/popup
D6215 / rEFL0dc492087ed0: edje_cc: temporarily disable aborting compile when namespace validation fails

Related Objects
Search...

		Status	Assigned	Task
		Resolved	segfaultxavi	T6966 fix part namespacing in default theme
		Resolved	segfaultxavi	T6965 uiclock theme parts are badly named
		Resolved	segfaultxavi	T6967 calendar theme parts are badly named
		Resolved	segfaultxavi	T7046 themes: ews/decoration e.icon.swallow part badly named
		Resolved	zmike	T7072 music_control.edc contains badly named signals
		Duplicate	segfaultxavi	T7074 themes: music_control has incorrect part names

zmike created this task.May 25 2018, 2:51 PM

zmike triaged this task as Showstopper Issues priority.

zmike added a subtask: T6965: uiclock theme parts are badly named.

zmike added a revision: D6215: edje_cc: temporarily disable aborting compile when namespace validation fails.May 25 2018, 3:00 PM

These errors can be seen by (locally) applying the patchset from D6215 for now or waiting until the feature is merged.

zmike edited projects, added Restricted Project; removed efl.Jun 11 2018, 6:50 AM

bu5hm4n edited projects, added efl: widgets; removed Restricted Project.Jun 11 2018, 7:23 AM

bu5hm4n added a project: efl (efl-1.21).Jun 12 2018, 8:44 AM

stephenmhouston added a commit: rEFL0dc492087ed0: edje_cc: temporarily disable aborting compile when namespace validation fails.Jun 15 2018, 10:27 AM

I'll create subtasks for complex widgets that require more time and try to fix the rest from this task.

vtorri added a subscriber: vtorri.Jun 22 2018, 12:48 PM

segfaultxavi added a revision: D6455: default theme: fix part names in elm/popup.Jun 27 2018, 10:05 AM

segfaultxavi added a revision: D6456: default theme: fix part names in elm/scrollable/panel.

segfaultxavi added a revision: D6457: default theme: fix part names in elm/ews.

segfaultxavi added a revision: D6458: default theme: fix group names in fileman.

segfaultxavi added a revision: D6459: default theme: fix group names in music_control.

segfaultxavi added a revision: D6460: default theme: fix part names in systray.

segfaultxavi added a revision: D6461: default theme: fix part names in illume.

segfaultxavi added a revision: D6462: default theme: fix part names in dialog.

segfaultxavi added a revision: D6463: default theme: fix part names in notification.

segfaultxavi mentioned this in T7092: default theme: review part names for new API widgets.Jun 28 2018, 11:03 AM

zmike added a commit: rEFL4d639df001ba: default theme: fix part names in elm/popup.Jun 29 2018, 8:30 AM

zmike added a commit: rEFLc35214ee9c4a: default theme: fix part names in elm/scrollable/panel.

zmike closed subtask T7046: themes: ews/decoration e.icon.swallow part badly named as Resolved.

zmike added a commit: rEFLcc4aff8640cf: default theme: fix group names in fileman.

zmike added a commit: rEFL17476212e59d: default theme: fix part names in systray.

zmike added a commit: rEFL97c51a670157: default theme: fix part names in illume.

zmike added a commit: rEFLc42a7b6bfe61: default theme: fix part names in dialog.

zmike added a commit: rEFLcf23ec291d04: default theme: fix part names in notification.

segfaultxavi closed subtask T6967: calendar theme parts are badly named as Resolved.Jun 29 2018, 8:41 AM

segfaultxavi closed subtask T6965: uiclock theme parts are badly named as Resolved.Jun 29 2018, 8:51 AM

segfaultxavi mentioned this in T6911: interface widgets use non-namespaced edje part names.Jul 5 2018, 6:31 AM

zmike closed subtask T7072: music_control.edc contains badly named signals as Resolved.Jul 5 2018, 1:59 PM

With T7072 resolved we are done with this one as well? At least it was the last missing subtask.

Yep. I tried to close it yesterday but it wouldn't let me.