efl internals pass null objects to functions which should not be passed null
Open, HighPublic
Actions

Description

An object function should never be passed null as the object. Example:

evas_object_geometry_get(NULL, &x, &y, &w, &h) is not a valid call.

This is a tracking ticket for the overall issue. eo.c:637 is the line of the error message and can be used with gdb to easily catch instances of it.

Details

Differential Revisions: D6703: elementary: Check for valid object before calling smart calculate
D6702: elementary: Check for valid object before calling efl internal functions
D6638: elementary: Check for valid resize obj before calling size_hint_combined_min_get
D6318: eo: upgrade missing parent WRN to ERR
Commits: D7677 / rEFLc98288c20eba: efl_ui_focus_object: Don't pass NULL to child_focus_set
D6704 / rEFL84423a465ca2: elementary: Check for valid focus manager before starting do loop
D6704 / rEFL364ca1d2b2bb: elementary: Check for valid focus manager before starting do loop
D6701 / rEFL6119cc0c65f0: elementary: Check for valid cursor_rect when (un)setting focus
D6641 / rE5af9485c4f5d: enlightenment: Ensure we have a valid menu comp object before calling
D6710 / rEFL2f9a65844e64: elementary: Check for valid object before calling smart calculate
D6641 / rEf2e0e2d785ce: enlightenment: Ensure we have a valid menu comp object before calling
D6640 / rEFL124703826f24: elementary: Check for valid resize object
D6639 / rEFLbe176bd3070e: elementary: Check for valid resize object before calling
D6637 / rEFL843b5177dfa0: elementary: Check for valid frame object
D6541 / rEFL7a538cbc4a6e: elm/ctxpopup: check for content object before removing callbacks during del
D6538 / rEFLee8d06c806f1: elementary: Avoid passing NULL in some win focus methods
D6317 / rEFL6f6b365c8431: elm_scroll: Avoid calls to non-existing part
D6323 / rEFL209aca1654c1: elm_colorselector: avoid passing null to efl functions
D6321 / rEFLb7cb24c32395: evas: switch to EFL_EVENT_INVALIDATE for event grabber sub-object deletion
D6316 / rEa6277f4f6d45: resolve a number of cases where a null object was passed to efl functions

Related Objects
Search...

Status	Assigned	Task
Open	devilhorns	T7030 efl internals pass null objects to functions which should not be passed null
Resolved	netstar	T7031 elm_code internals pass null to functions
Resolved	bu5hm4n	T7032 eo calls parent_set with null parent during construction
Resolved	zmike	T7033 elm_win passes null to functions
Resolved	bu5hm4n	T7034 focus manager passes null
Resolved	zmike	T7035 elm_list passes null to functions
Resolved	zmike	T7036 elm_colorselector passes null to functions
Resolved	devilhorns	T7076 calendar widget: do not pass NULL to eo methods
Resolved	bu5hm4n	T7224 eina safety check failed, obj == NULL in evas_object_event_callback_del_full in lib/evas/canvas/evas_callbacks.c:539
Resolved	bu5hm4n	T7213 efl_ui_calendar crash issue.
Resolved	None	T7265 elm_panel.c: _elm_panel_elm_layout_sizing_eval() safety check failed: efl_finalized_get(obj) is false
Resolved	devilhorns	T7266 evas_object_event_callback_del_full() safety check failed: eo_obj == NULL

zmike created this task.Jun 18 2018, 10:11 AM

zmike triaged this task as High priority.

As of current master, running with EINA_LOG_LEVELS=eo:2 can be used to print messages when this occurs.

zmike added a project: efl: data types.Jun 18 2018, 10:27 AM

zmike added a revision: D6316: resolve a number of cases where a null object was passed to efl functions.Jun 18 2018, 11:36 AM

zmike added a revision: D6317: elm_scroll: Avoid calls to non-existing part.Jun 18 2018, 12:59 PM

zmike added a revision: D6318: eo: upgrade missing parent WRN to ERR.

zmike added a revision: D6321: evas: switch to EFL_EVENT_INVALIDATE for event grabber sub-object deletion.

zmike added a revision: D6323: elm_colorselector: avoid passing null to efl functions.

P220 has a full log of all the errors along with backtraces at the current time (as of D6325).

If you want to pitch in, pick a widget, create a subtask for the widget and assign it to yourself. Most of the work is just adding null checks here and there.

zmike mentioned this in D6326: edje: Demote 'No such part...' from WRN to DBG.Jun 19 2018, 7:33 AM

devilhorns added a commit: rEa6277f4f6d45: resolve a number of cases where a null object was passed to efl functions.Jun 19 2018, 9:38 AM

zmike closed subtask T7032: eo calls parent_set with null parent during construction as Resolved.Jun 19 2018, 10:36 AM

zmike closed subtask T7033: elm_win passes null to functions as Resolved.Jun 19 2018, 10:42 AM

zmike added a commit: rEFLb7cb24c32395: evas: switch to EFL_EVENT_INVALIDATE for event grabber sub-object deletion.

zmike added a commit: rEFL209aca1654c1: elm_colorselector: avoid passing null to efl functions.

zmike closed subtask T7036: elm_colorselector passes null to functions as Resolved.

zmike closed subtask T7035: elm_list passes null to functions as Resolved.

devilhorns added a subscriber: devilhorns.Jun 19 2018, 1:30 PM

Diffusion added a commit: rEFL6f6b365c8431: elm_scroll: Avoid calls to non-existing part.Jun 25 2018, 2:41 AM

I'll get started on this one tomorrow

Diffusion closed subtask T7034: focus manager passes null as Resolved.Jul 2 2018, 9:23 AM