Page MenuHomePhabricator

efl_ui_text does use format and mode wrong
Open, HighPublic

Description

_efl_ui_text_cnp_mode_set takes a format as argument, but sets the correct mode in the constructor, something seems off and produces those warnings:

lib/elementary/efl_ui_text.c:3559:21: warning: comparison of two values with different enumeration types ('Elm_Cnp_Mode' and 'Elm_Sel_Format' (aka 'Efl_Selection_Format')) [-Wenum-compare]
   if (sd->cnp_mode == cnp_format) return;
       ~~~~~~~~~~~~ ^  ~~~~~~~~~~
lib/elementary/efl_ui_text.c:3559:21: warning: comparison of integers of different signs: 'Elm_Cnp_Mode' and 'Elm_Sel_Format' (aka 'Efl_Selection_Format') [-Wsign-compare]
   if (sd->cnp_mode == cnp_format) return;
       ~~~~~~~~~~~~ ^  ~~~~~~~~~~
bu5hm4n created this task.Jun 23 2018, 9:30 AM
bu5hm4n triaged this task as High priority.