Page MenuHomePhabricator
Create Task
Maniphest T7171

Rename ecore_wl2
Closed, InvalidPublic
Actions

Description

Due to unforeseen circumstances external users have become dependent on ecore_wl2 ABI. Since this library is still beta, we can surrender the name space and allow the external user to maintain ABI compatibliity without great harm to EFL. I suspect part of this stems from eo and ecore_wl2 being gated by the same #define.

This work includes:
Renaming the library
Updating all efl call sites
Removing all API not strictly required by E from the public header
Replacing the conventional BETA_API defines with a more specific define that only E will use
Updating E appropriately

Details

Differential Revisions
D7881: wayland: Rename ecore_wl2 to notstable
ManMower created this task.Jul 19 2018, 3:08 PM
zmike added a comment.Jul 19 2018, 3:11 PM

I would propose that we completely eliminate functions from the public header. Users of the API can manually declare the function prototypes and if they break then it's an application bug.

The header should contain nothing but the following as-is:

This namespace will not be stable. It will change. Do not ever use it.

Anyone who tries to include it will then get a compile failure since this is obviously not C, and therefore they will be adequately warned and future instances of this can be prevented.

devilhorns added a comment.Jul 19 2018, 3:50 PM

This may also be the perfect time to fix https://phab.enlightenment.org/T5181 also....

bu5hm4n added projects: efl: display system, Restricted Project.Jul 22 2018, 2:11 AM
zmike triaged this task as TODO priority.Jul 30 2018, 1:18 PM
zmike edited projects, added Active Work Proposal; removed Voting.Aug 20 2018, 4:55 AM
ManMower removed ManMower as the assignee of this task.Feb 14 2019, 12:13 PM
devilhorns claimed this task.Tue, Jan 19, 1:57 PM
devilhorns closed this task as Invalid.

Yea....not going to happen