Page MenuHomePhabricator

main.c:67]: (style) Suspicious condition
Open, Pending on user inputPublic

Description

main.c:67]: (style) Suspicious condition (assignment + comparison); Clarify expression with parentheses.

Source code is

while ((ret = read(0, &(buf[j]), 1) > 0))

maybe better code

while ((ret = read(0, &(buf[j]), 1)) > 0)
dcb created this task.Aug 14 2018, 11:35 AM
ProhtMeyhet triaged this task as Pending on user input priority.Sep 22 2018, 11:06 AM
ProhtMeyhet added a subscriber: ProhtMeyhet.

where is this line of code?

is it in

  • enlightenment
  • efl
  • or some other application

?

dcb added a comment.Sep 23 2018, 3:13 AM

I've long since forgotten. Suggest something like

find $PROJECT_1 $PROJECT_2 -name main.c -print

Have a look at line 67 of each file.